-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Jackson XML publishing missing elements/attributes #3316
Comments
We will have to evaluate that but for now maintain the functionality as was. |
@muloem to react to your question:
I say no mostly because we should stick to the rule, one answer = one value, so if you need to scan more things, that should be handled with multiple barcode questions. I am also not sure how barcodes are actually used in the field. I only know one case where: the barcode is attached to an e.coli water quality sample bag and the code is scanned to Flow, so after the incubation time you can register the result to the proper data point. Ideally, we would check if and how this question type is used on partner instances and limit to only one barcode per answer (if the data proves this assumption right) |
* Rearranging attributes of the XMLForm class to match to the same order in which were generated in the `<survey>` element of the previous XMLForm generation code * Modify the expected string output in the test classes to match the rearranged attributes.
…tes-order [#3316] Refactor XMLForm survey attributes order
fixed them all to avoid copy pasting the same error again
Which allowMultiple is not set for option questions? Pretty sure the one in the options container is set. |
[#3316] fix repeatable group should not be set when false
* avoid NPE translation map * add tests * return default renderType * reorder fields as were before
There are still some difference Do not create any issues on the Android app:
|
I feel pretty certain that I did the work on |
[#3316] Add registration survey attribute to XML form
[#3316] fix for non repeatable groups survey xml files
All fixed! |
The newly implemented Jackson XML publishing from #3115 has some attributes missing or wrongly configured. We will track and fix them here
registrationSurveyId
attribute is missing from the<survey></survey>
elementthe expected would be
<question order="1" type="free" mandatory="true" localeNameFlag="false" id="381322013" variableName="SomeVar">
app
attribute is missing from the<survey>
elementallowMultiple
is not set for option questions.allowMultiple="true"
is not set. Do we actually need multiple Barcode scans in one question?repeatable
attribute forQuestionGroup
is set even in cases where its false. We dont include it when its false.The text was updated successfully, but these errors were encountered: