Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Publish form using Jackson fasterxml library #3115

Closed
stellanl opened this issue Jun 11, 2019 · 7 comments
Closed

Publish form using Jackson fasterxml library #3115

stellanl opened this issue Jun 11, 2019 · 7 comments
Assignees
@stellanl
Milestone
1.10.1

Comments

@stellanl
Copy link
Contributor

Since #2285 added classes for parsing form XML, with a little extra work we can do the publishing using the same infrastructure, improving the likelihood they are compatible.
@stellanl stellanl self-assigned this Jun 11, 2019
@stellanl
Copy link
Contributor Author

stellanl commented Aug 5, 2019 •
edited
Loading

Basic pattern is to add a constructor for most of the XML-classes (those that correspond to domain classes) that takes a domain object parameter.

@muloem muloem mentioned this issue Aug 5, 2019
Closed
stellanl added a commit that referenced this issue Aug 7, 2019
@stellanl
[#3115]Make parser accept a form without question-groups. Add a test …
368f27b 
…for that. Start on XML generation. Add a test class for that.
stellanl added a commit that referenced this issue Sep 2, 2019
@stellanl
[#3115]Create jackson objects from domain objects. Add Cascade levels…
e643a0d 
… to Question.
@stellanl
Copy link
Contributor Author

It is a bit tricky to test this end-to-end as we need to create datastore Key objects.

stellanl added a commit that referenced this issue Sep 28, 2019
@stellanl
[#3115]Add dependencies. Generate keys.
8f101cc
stellanl added a commit that referenced this issue Sep 30, 2019
@stellanl
[#3115]Move to test source tree. Add more tests.
c8a70a1
stellanl added a commit that referenced this issue Sep 30, 2019
@stellanl
[#3115]Make test dependecies use test scope.
7c3d042
stellanl added a commit that referenced this issue Oct 1, 2019
@stellanl
[#3115]Add in missing form attributes. Do not test same thing twice.
55baf58
stellanl added a commit that referenced this issue Oct 1, 2019
@stellanl
[#3115]Force writing of declaration. (standalone=yes still missing)
81cd191
stellanl added a commit that referenced this issue Oct 3, 2019
@stellanl
[#3115]Add XML declaration. Add pretty-printing method.
85d4874
stellanl added a commit that referenced this issue Oct 8, 2019
@stellanl
[#3115]Add more tests.
636e417
stellanl added a commit that referenced this issue Oct 9, 2019
@stellanl
[#3115]Make the correct attributes optional, and adjust the tests.
f55c748
stellanl added a commit that referenced this issue Oct 9, 2019
@stellanl
[#3115]Remove old assembly code.
ac3d895
@stellanl
Copy link
Contributor Author

stellanl commented Oct 18, 2019 •
edited
Loading

It just occurred to me the since the published form will now be the base for the reports, we need to invalidate the cached reports for the form.

@muloem
Copy link
Member

muloem commented Oct 18, 2019

Which cached reports are you referring to here? Survey forms or Comprehensive reports?

@stellanl
Copy link
Contributor Author

stellanl commented Oct 18, 2019 •
edited
Loading

Comprehensive and data cleaning.
The survey forms export is another thing that we may want to be based on the published form, but that should be another issue.

stellanl added a commit that referenced this issue Oct 18, 2019
@stellanl
[#3115]Add report cache invalidation. Rename to use 'form' instead of…
3f41511 
… 'survey' where appropriate.
stellanl added a commit that referenced this issue Oct 30, 2019
@stellanl
[#3115]Add expected XML strings to tests. Optimise Questions fetch. L…
9088cb3 
…ower log level. Use equals() instead of ==.
stellanl added a commit that referenced this issue Nov 5, 2019
@stellanl
[#3115]Wrangle package-lock
fd6fab8
stellanl added a commit that referenced this issue Nov 6, 2019
@stellanl
[#3115]One last equals sign
a868298
stellanl added a commit that referenced this issue Nov 6, 2019
@stellanl
[#3115]Check out assumption.
9e9d9d5
stellanl added a commit that referenced this issue Nov 7, 2019
@stellanl
Merge pull request #3220 from akvo/issue/3115-publish-form-using-jackson
b7cc41c 
Issue/3115 publish form using jackson (Connect #3115)
@janagombitova
Copy link
Contributor

Is this issue done done and can it be closed?

muloem added a commit that referenced this issue Nov 12, 2019
@muloem
[#3115] Refactor form loading code to improve performance
393a872 
* We remove code that is querying the `QuestionHelpMedia` entity that is no longer used.
* Rename the function to match domain names (Form)
* Remove unused import
muloem added a commit that referenced this issue Nov 12, 2019
@muloem
Merge pull request #3294 from akvo/issue/3115-publish-form-using-jackson
b25bd16 
[#3115] Refactor form loading code to improve performance
@muloem
Copy link
Member

muloem commented Nov 14, 2019

Tested several variations of publishing and large surveys. Good to go. 👍

@valllllll2000 valllllll2000 mentioned this issue Nov 20, 2019
Closed
@muloem muloem mentioned this issue Nov 21, 2019
Closed
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@stellanl stellanl

Labels
None yet
Projects
None yet
Milestone
1.10.1
Development

No branches or pull requests
3 participants
@stellanl @muloem @janagombitova