Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#3316] Fixes for question options #3325

Merged
merged 2 commits into from
Nov 25, 2019
Merged

[#3316] Fixes for question options #3325

merged 2 commits into from
Nov 25, 2019

Conversation

valllllll2000
Copy link
Contributor

@valllllll2000 valllllll2000 commented Nov 25, 2019 •
edited
Loading

Before the PR (what is the issue or what needed to be done)

The solution

  • avoid NPE translation map
  • add tests
  • return default renderType
  • reorder fields as were before

Screenshots (if appropriate)

Checklist

  • Connect the issue
  • Test plan
  • Copyright header
  • Code formatting
  • Documentation

@valllllll2000
[#3316] Fixes for question options
22aed44 
* avoid NPE translation map
* add tests
* return default renderType
* reorder fields as were before
@valllllll2000
[#3316] reverted unnecessary change
ffd5244
stellanl
stellanl approved these changes Nov 25, 2019
View reviewed changes
Copy link
Contributor

@stellanl stellanl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code reviewed

@stellanl stellanl merged commit 97fbdb7 into develop Nov 25, 2019
@stellanl stellanl deleted the issue/3316-option-fixes branch November 25, 2019 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stellanl stellanl stellanl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@valllllll2000 @stellanl