Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#3316] Add registration survey attribute to XML form #3361

Merged
merged 2 commits into from
Dec 17, 2019
Merged

[#3316] Add registration survey attribute to XML form #3361

merged 2 commits into from
Dec 17, 2019

Conversation

muloem
Copy link
Member

@muloem muloem commented Dec 17, 2019

Before the PR (what is the issue or what needed to be done)

  • Registration survey id missing form the generated XML form definition

The solution

  • registrationSurvey attribute is now included in XML form

Screenshots (if appropriate)

Reviewer Checklist

  • Added an explanation about the work done
  • Connected the PR and the issue on Zenhub
  • Added a test plan to the issue
  • Updated the copyright header (when relevant)
  • Formatted the code
  • Added a documentation (if relevant)
  • Added some unit tests (if relevant)

@muloem muloem requested a review from valllllll2000 December 17, 2019 13:11
@muloem muloem changed the title Issue/3316 registration survey [#3316] Add registration survey attribute to XML form Dec 17, 2019
@valllllll2000 valllllll2000 merged commit 642b11d into release/1.10.1.1 Dec 17, 2019
@valllllll2000 valllllll2000 deleted the issue/3316-registration-survey-id branch December 17, 2019 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@valllllll2000 valllllll2000 valllllll2000 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@muloem @valllllll2000