Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#3316] Refactor XMLForm survey attributes order #3321

Merged
merged 4 commits into from
Nov 25, 2019
Merged

[#3316] Refactor XMLForm survey attributes order #3321

merged 4 commits into from
Nov 25, 2019

Conversation

muloem
Copy link
Member

@muloem muloem commented Nov 22, 2019

The solution

  • Reorder the attributes to match the previous XML generation format

Screenshots (if appropriate)

Checklist

  • Connect the issue
  • Test plan
  • Copyright header
  • Code formatting
  • Documentation

@muloem
[#3316] Refactor XmlForm and update tests
026d9a7
@muloem
[#3316] Refator existing tests and order of survey attributes
f22b8a9 
* Rearranging attributes of the XMLForm class to match to the same order in which were generated in the `<survey>` element of the previous XMLForm generation code
* Modify the expected string output in the test classes to match the rearranged attributes.
@muloem
[#3316] Remove test that has no assertions/expected values defined
c2f4aab
@muloem
[#3316] Restore wrongly removed test + remove test without assertions
5187817
@muloem muloem requested a review from valllllll2000 November 22, 2019 19:14
@valllllll2000 valllllll2000 merged commit c42e3b0 into develop Nov 25, 2019
@valllllll2000 valllllll2000 deleted the issue/3316-refactor-survey-attributes-order branch November 25, 2019 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@valllllll2000 valllllll2000 valllllll2000 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@muloem @valllllll2000