Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#3316] fix for non repeatable groups survey xml files #3362

Merged
merged 1 commit into from
Dec 17, 2019
Merged

[#3316] fix for non repeatable groups survey xml files #3362

merged 1 commit into from
Dec 17, 2019

Conversation

valllllll2000
Copy link
Contributor

@valllllll2000 valllllll2000 commented Dec 17, 2019 •
edited
Loading

Before the PR (what is the issue or what needed to be done)

when a group is non repeatable

The solution

fix when non repeatable group we should not pass repeatable=false

Screenshots (if appropriate)

NA

Reviewer Checklist

  • Added an explanation about the work done
  • Connected the PR and the issue on Zenhub
  • Added a test plan to the issue
  • Updated the copyright header (when relevant)
  • Formatted the code
  • Added a documentation (if relevant)
  • Added some unit tests (if relevant)

stellanl
stellanl approved these changes Dec 17, 2019
View reviewed changes
Copy link
Contributor

@stellanl stellanl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed

@stellanl stellanl merged commit 8078a33 into release/1.10.1.1 Dec 17, 2019
@stellanl stellanl deleted the issue/3316-repeatable-false-removal branch December 17, 2019 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stellanl stellanl stellanl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@valllllll2000 @stellanl