Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#3316] fix repeatable group should not be set when false #3322

Merged
merged 3 commits into from
Nov 25, 2019
Merged

[#3316] fix repeatable group should not be set when false #3322

merged 3 commits into from
Nov 25, 2019

Conversation

valllllll2000
Copy link
Contributor

@valllllll2000 valllllll2000 commented Nov 25, 2019 •
edited by muloem
Loading

Before the PR (what is the issue or what needed to be done)

The solution

repeatable should be either true missing from form xml

Screenshots (if appropriate)

Checklist

  • Connect the issue
  • Test plan
  • Copyright header
  • Code formatting
  • Documentation

@valllllll2000 valllllll2000 requested a review from muloem November 25, 2019 10:09
Valeria Rogatchevskikh and others added 2 commits November 25, 2019 14:12
@muloem
Update GAE/test/org/akvo/flow/xml/FlowXmlObjectWriterTests.java
5608178 
Co-Authored-By: Emmanuel Mulo <[email protected]>
@valllllll2000
[#3316] fix QuestionGroup key generation
fb19321 
fixed them all to avoid copy pasting the same error again
@valllllll2000 valllllll2000 merged commit bb14f2a into develop Nov 25, 2019
@valllllll2000 valllllll2000 deleted the issue/3316-repeatable-group branch November 25, 2019 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@muloem muloem muloem approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@valllllll2000 @muloem