Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Selection of datapoints to assign to a device #3168

Closed
muloem opened this issue Aug 21, 2019 · 11 comments
Closed

Selection of datapoints to assign to a device #3168

muloem opened this issue Aug 21, 2019 · 11 comments
Assignees
Milestone

Comments

@muloem
Copy link
Member

muloem commented Aug 21, 2019

As part of #2796, we will enable selection of datapoints to assign to a specific device in an assignment. This is the UI work related to #3166 that will communciate with the backend to create and update the list of datapoints assigned to a device.

Initial MVP simply shows a list of datapoints selected if present or none if they are not selected.

Screenshot 2019-08-21 at 16 47 16

And a layover? when Assign datapoints is selected to list all the datapoints to make a selection of the ones to be assigned to a device.

@janagombitova
Copy link
Contributor

janagombitova commented Oct 14, 2019

For all the details check: #2796

With 1.10 we changed how Assignments work to ensure one assignment can only hold forms from one survey and we redesigned the form and device selectors. These changes were needed to implement the MVP of allowing to assign data points to devices.

Requirements

For all the details please check the mock ups. You can find the full mockups here: https://projects.invisionapp.com/share/NHQGVLB2EKX#/screens/346093699_0-0_Assignments_ES

Creating a new assignment

The expected user behaviour that we will support is:

  1. Salim creates a new assignment - gives it a name, dates and selects the survey and forms and which devices will collect data for this/these forms.
  2. IMPORTANT: If Salim selects a monitoring survey (with monitoring enabled) he can also assign data points to the selected devices. If he selected a survey that does not have monitoring enables, assigning data points is not available to him.
  3. He selects a device. It is highlighted in the UI.
  4. He clicks to Assign data points (for the selected device or device group).
  5. He sees two options: By data point name or ID, Assign all data points.
  6. He selects how he will assign his data points. @Kiarii how will we handle if there are no data points yet to assign in this MVP?
    6a. If he selects to Assign all data points, all the data points will be sent to that selected device.
    6b. If he selects By data point name or id, he will see a search bar when he types the name or ID and matching data points show in the list with the option to assign to the device.
  7. Once data points are assigned to the device show behind the device the number of points assigned to that device (not in the mock ups).

Editing an existing assignment.

Please note this is different than in the mockups. This is because not all assignments will have data points assigned in them so it is more important to show the dates, survey - forms and devices and have Salim take the extra steps to see the assigned data points.

If Salim opens an existing assignment to check out its details, he sees the assignment name, dates, forms and devices (next to each device the number of data points assigned). If he wants to edit the assigned data points he needs to click on the device first to see which data points exactly are assigned to it.

@Kiarii
Copy link

Kiarii commented Oct 14, 2019

He selects how he will assign his data points. @Kiarii how will we handle if there are no data points yet to assign in this MVP?

@janagombitova am thinking that we had storymapped this or specified somewhere else what would take place, am looking Mural but cant seem to find what we had decided/put down,

@janagombitova
Copy link
Contributor

@Kiarii all the decisions are in the Epic: #2796 but there is a chance we did not talk about some specifics, like this one: If it go to Assign data points but the survey has no data points yet, where do I see that?

@Kiarii
Copy link

Kiarii commented Oct 14, 2019

if there are no data points yet to assign, we will indicate this to the user as follows:
image

@janagombitova janagombitova added this to the 1.10.1 milestone Oct 15, 2019
@janagombitova janagombitova modified the milestones: 1.10.1, 1.10.2 Nov 6, 2019
@janagombitova
Copy link
Contributor

Yesterday we went through the mock-ups again with @Kiarii, @muloem and @marvinkome. Here are the notes with the expected behaviour. We agreed:

  • assigning data points will only be enabled for monitoring surveys
  • you can assign one data point to multiple devices
  • you will be able to assign data points one device at a time to start with, not enabling to assign data points for an entire group of devices (Needs a new separate issue)
  • picking the data points will happen by searching - Salim will type in a keyword, hit the search icon/or press Enter and Flow will give the relevant results
  • if the list of data points is too long scrolling will happen on the list but keeping all other elements (as action button or the search bar) insight.

More here:
Assign data points.pdf

Kiarii will further define the workflow on how to edit the data points that are already assigned to the device.

@janagombitova
Copy link
Contributor

janagombitova commented Nov 13, 2019

Fresh mockups to come... we pivoted on the entire screen layout. More info here #3297

@janagombitova
Copy link
Contributor

The final mockups are here: https://projects.invisionapp.com/share/5YUUUPXF7DA#/screens

@muloem
Copy link
Member Author

muloem commented Dec 9, 2019

@marvinkome please read through these comments as there will be a change in the implementation #2796 (comment)

marvinkome pushed a commit that referenced this issue Dec 19, 2019
@muloem muloem modified the milestones: 1.10.1.3, 1.10.2 Dec 19, 2019
marvinkome pushed a commit that referenced this issue Dec 20, 2019
marvinkome pushed a commit that referenced this issue Jan 28, 2020
marvinkome pushed a commit that referenced this issue Jan 28, 2020
marvinkome pushed a commit that referenced this issue Jan 28, 2020
marvinkome pushed a commit that referenced this issue Jan 28, 2020
[#3168] - assign datapoints to assignments by name [no api included yet]
marvinkome pushed a commit that referenced this issue Jan 30, 2020
marvinkome pushed a commit that referenced this issue Jan 31, 2020
marvinkome pushed a commit that referenced this issue Feb 3, 2020
marvinkome pushed a commit that referenced this issue Feb 3, 2020
marvinkome pushed a commit that referenced this issue Feb 3, 2020
marvinkome pushed a commit that referenced this issue Feb 4, 2020
marvinkome pushed a commit that referenced this issue Feb 4, 2020
marvinkome pushed a commit that referenced this issue Feb 5, 2020
…n-datapoints

[#3168] - add survey edge cases on datapoints
marvinkome pushed a commit that referenced this issue Feb 5, 2020
marvinkome pushed a commit that referenced this issue Feb 7, 2020
marvinkome pushed a commit that referenced this issue Feb 7, 2020
[#3168] - clean up and handle edge cases with creating new assignment
@Kiarii
Copy link

Kiarii commented Mar 3, 2020

@muloem has made a suggestion that we consider using walkthroughs to introduce new features or actions that users can now do; For this page, one of those actions is the "Assign Datapoints" which we can introduce or highlight as follows (the text is up for adjustment..)
image

@Kiarii
Copy link

Kiarii commented Mar 16, 2020

@marvinkome I was going via the assignments and noted that there are a few things needing refinement;

  • The "Assign datapoints by name or id" is active if the "Assign all datapoints" is not used (Small changes to unassigning all datapoitns #3499)
  • The "Assign datapoints by name or id" panel is a side panel not a pop-up; the idea being that the user can see what is already assigned as they continue to search and assign more datapoints
  • To "unassign datapoints" we cannot say "cancel assignment" this creates a logical confusion with assignments themselves.. Lets use "unassign datapoints." "unassign" might not be a proper English word but if users understand it, there is no need to use more complex or ambiguous terminology (Small changes to unassigning all datapoitns #3499)
  • With Assign all datapoints, we should give the actual figure; X datapoints assigned (will be handled in Show number of datapoints assigned for a device #3496)
  • Disable Edit action for a device if no datapoint have been assigned to it. When enabled, Edit should use the same color as other clickable elements so it is easily seen
  • Saving an assignment should not navigate the user to the assignment list > the user should remain in the assignment and navigate away from it should an explicit action that they do.. (will be handled in Saving should not take user back to assignments list #3436)
  • Walkthrough coming soon (will be handled in Walkthrough for datapoint assignments #3466)

@janagombitova
Copy link
Contributor

The core of the work here is done. More adjustments and improvements will follow (see also the comment above) but to keep the issues organised we will use the label 1-Assignments. So when it comes to this issue the goal was to make it possible to assign datapoints. That is done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants