Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#3168] - add survey edge cases on datapoints #3398

Merged
merged 9 commits into from
Feb 5, 2020
Merged

[#3168] - add survey edge cases on datapoints #3398

merged 9 commits into from
Feb 5, 2020

Conversation

marvinkome
Copy link
Contributor

@marvinkome marvinkome commented Jan 21, 2020 •
edited
Loading

Make the following fixes for datapoints - survey relationship

  • Search for data points in the selected survey folder
  • Search for data points starting with a specific name
  • Search for data points by ID
  • Empty data points when a new survey folder is selected

Screenshots (if appropriate)

Reviewer Checklist

  • Added an explanation about the work done
  • Connected the PR and the issue on Zenhub
  • Added a test plan to the issue
  • Updated the copyright header (when relevant)
  • Formatted the code
  • Added a documentation (if relevant)
  • Added some unit tests (if relevant)

@marvinkome marvinkome requested a review from muloem January 21, 2020 11:22
@marvinkome marvinkome mentioned this pull request Jan 27, 2020
Merged
7 tasks
@marvinkome marvinkome merged commit fa1f801 into develop Feb 5, 2020
@marvinkome marvinkome deleted the issue-3168/add-survey-edge-cases-on-datapoints branch February 5, 2020 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@muloem muloem muloem approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@marvinkome @muloem