-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#3168] - save datapoints in api #3396
Conversation
P.S Happy holidays
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Try to review the datastructures to ensure that whats contained in them is accurately reflected by the name. e.g. an array of Ids should have something referring to Ids in its name in order to distinguish it from an array of objects.
Dashboard/app/js/lib/components/devices/AssignmentsEditView/screens/AddDevices.jsx
Outdated
Show resolved
Hide resolved
Dashboard/app/js/lib/components/devices/AssignmentsEditView/screens/EditDevices.jsx
Outdated
Show resolved
Hide resolved
Dashboard/app/js/lib/components/devices/AssignmentsEditView/screens/EditDevices.jsx
Outdated
Show resolved
Hide resolved
There's a bug where Datapoints isn't being saved because |
Dashboard/app/js/lib/components/devices/AssignmentsEditView/screens/AssignDatapoints/index.jsx
Outdated
Show resolved
Hide resolved
Dashboard/app/js/lib/components/devices/AssignmentsEditView/screens/EditDevices.jsx
Outdated
Show resolved
Hide resolved
Dashboard/app/js/lib/components/devices/AssignmentsEditView/screens/EditDevices.jsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Before the PR (what is the issue or what needed to be done)
Datapoints were only stored in memory and not saved in the data store.
The solution
Store datapoints with the API and fetch back datapoint assignments when editing assignments
Screenshots (if appropriate)
Reviewer Checklist