Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#3168] - save datapoints in api #3396

Merged
merged 14 commits into from
Feb 3, 2020
Merged

Conversation

marvinkome
Copy link
Contributor

@marvinkome marvinkome commented Jan 17, 2020

Before the PR (what is the issue or what needed to be done)

Datapoints were only stored in memory and not saved in the data store.

The solution

Store datapoints with the API and fetch back datapoint assignments when editing assignments

Screenshots (if appropriate)

Reviewer Checklist

  • Added an explanation about the work done
  • Connected the PR and the issue on Zenhub
  • Added a test plan to the issue
  • Updated the copyright header (when relevant)
  • Formatted the code
  • Added a documentation (if relevant)
  • Added some unit tests (if relevant)

@marvinkome marvinkome requested a review from muloem January 17, 2020 14:34
Copy link
Member

@muloem muloem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Try to review the datastructures to ensure that whats contained in them is accurately reflected by the name. e.g. an array of Ids should have something referring to Ids in its name in order to distinguish it from an array of objects.

@marvinkome
Copy link
Contributor Author

There's a bug where Datapoints isn't being saved because surveyAssignment keyId isn't yet available when creating new surveyAssignment, this bug was fixed in this PR #3404

@marvinkome marvinkome requested a review from muloem January 30, 2020 08:51
@marvinkome marvinkome requested a review from muloem January 30, 2020 16:01
@marvinkome marvinkome requested a review from muloem January 31, 2020 15:38
Copy link
Member

@muloem muloem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When trying to assign the datapoints I get a blank screen and this error in the console.

Screenshot 2020-01-31 at 18 38 55

@marvinkome marvinkome requested a review from muloem February 3, 2020 08:47
@marvinkome marvinkome merged commit 308ac4f into develop Feb 3, 2020
@marvinkome marvinkome deleted the issue-3168/save-datapoints-in-api branch February 3, 2020 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants