Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#3168] - clean up and handle edge cases with creating new assignment #3404

Merged
merged 15 commits into from
Feb 7, 2020
Merged

[#3168] - clean up and handle edge cases with creating new assignment #3404

merged 15 commits into from
Feb 7, 2020

Conversation

marvinkome
Copy link
Contributor

The solution

Fix bugs that occur while creating new assignments, and clean up (basically add more comments) in assignment-edit page

Reviewer Checklist

  • Added an explanation about the work done
  • Connected the PR and the issue on Zenhub
  • Added a test plan to the issue
  • Updated the copyright header (when relevant)
  • Formatted the code
  • Added a documentation (if relevant)
  • Added some unit tests (if relevant)

@marvinkome marvinkome requested a review from muloem January 28, 2020 12:11
@marvinkome marvinkome mentioned this pull request Jan 29, 2020
Merged
7 tasks
@marvinkome marvinkome requested a review from muloem February 7, 2020 08:03
@marvinkome marvinkome merged commit 2304f9b into develop Feb 7, 2020
@marvinkome marvinkome deleted the issue-3168/refactor-assignment branch February 7, 2020 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@muloem muloem muloem approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@marvinkome @muloem