Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show number of datapoints assigned for a device #3496

Closed
muloem opened this issue Apr 8, 2020 · 3 comments
Closed

Show number of datapoints assigned for a device #3496

muloem opened this issue Apr 8, 2020 · 3 comments
Assignees
@iperdomo
Labels
1 - Assignment

Comments

@muloem
Copy link
Member

muloem commented Apr 8, 2020

Context

We introduced the new datapoints assignment functionality that, by default, assigns all datapoints in a monitoring survey to every device added to the assignment.

Problem or idea

When this "assign all datapoints" option is selected, we have no clue how many datapoints have been assigned to a device. We also do not want to download all the datapoints from the backend to handle that processing in the frontend, i.e .just to count how many of the datapoints are assigned.

Solution or next step

Have the backend return a count of the number of datapoints associated with a survey?
@Kiarii Kiarii mentioned this issue Apr 8, 2020
Closed
@iperdomo
Copy link
Contributor

iperdomo commented Apr 9, 2020

This is a new requirement, right? In the previous state of assignments, the user also didn't know how many datapoints were assigned.

Thinking on implementation, giving no numbers is better than reporting wrong numbers. IMHO

We know we can't do a SELECT count(*) FROM datapoints WHERE surveyId = ?, in order to not waste a load of all and then throwing away just for counting, we need to cache the count, and we know how that will go (:point_down: just to link to some count related issues)

iperdomo added a commit that referenced this issue Apr 9, 2020
@iperdomo
[#3496] Adds countBySurveyGroupId
becb242 
Unfortunately we can't use JDO with `KeysOnly` queries.

The current documentation states the following:

    Query q = new Query("Person").setKeysOnly();

Translates to this query in JDO

    Query q = pm.newQuery("select id from " + Person.class.getName());
    List<String> ids = (List<String>) q.execute();

When trying this approach DataNucleus fails with

   "Variable expression is not supported by this mapper"

Since we're using the "low-level" API at the BaseDAO class,
we implemented a generic countByFilterProperty as a way of doing
an efficient Key-Only query.
iperdomo added a commit that referenced this issue Apr 9, 2020
@iperdomo
[#3496] Update copyright header
3baa629
iperdomo added a commit that referenced this issue Apr 9, 2020
@iperdomo
[#3496] Add new enpoint /surveyed_locale_count
16b47e4 
* The endpoint expects a `surveyGroupId=<id>` as query parameter
* Returns a JSON response with the usual `meta` key, plus
  a `surveyedLocaleCount` key with number of datapoints for
  that Survey
iperdomo added a commit that referenced this issue Apr 9, 2020
@iperdomo
[#3496] Fix datapoint test count
4ef0303 
The previous state of the test only generated instances for the same
surveyGroupId we were checking. So there was a bug in the test,
the covered a bug in the code :/
iperdomo added a commit that referenced this issue Apr 9, 2020
@iperdomo
[#3496] Introduce a Ember Data model to query Datapoint count
2f01be0 
The count of datapoints for a given Survey can be done by:

    FLOW.store.findById(FLOW.SurveyedLocaleCount, <surveyGroupId>)

Response Example:

{"surveyed_locale_count":{"count":167,"keyId":"152342023"}}
@iperdomo iperdomo self-assigned this Apr 10, 2020
iperdomo added a commit that referenced this issue Apr 10, 2020
@iperdomo
[#3496] Show datapoint count when visiting a device assignment
742ed5a 
- Update the string used to have a "placeholder" and replace
  it with the actual number
- We need to update the translations
@janagombitova
Copy link
Contributor

This is a handy change. Works well as far as I can tell on uat2

@janagombitova janagombitova reopened this Apr 14, 2020
@janagombitova
Copy link
Contributor

If all is done, please close the issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@iperdomo iperdomo

Labels
1 - Assignment
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@iperdomo @muloem @janagombitova