Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add JSX transpiler to dashboard build process (estimated: 1) #1502

Closed
muloem opened this issue Nov 24, 2015 · 7 comments
Closed

Add JSX transpiler to dashboard build process (estimated: 1) #1502

muloem opened this issue Nov 24, 2015 · 7 comments
Assignees
@muloem @finnfiddle
Labels
Deployment & infrastructure
Milestone
1.9.45 Radiant Ra...

Comments

@muloem
Copy link
Member

muloem commented Nov 24, 2015 •
edited by janagombitova
Loading

As part of the introduction of react components in the dashboard, we need to be able to compile JSX to JS code that will be embedded in different parts of the ember dashboard code. This requires including JSX transpiler tools in our current build process.

Child of #2796
@muloem muloem self-assigned this Nov 25, 2015
@muloem muloem modified the milestone: 1.9.4 Dec 1, 2015
@muloem muloem modified the milestones: 1.9.5, 1.9.4 Dec 28, 2015
@rumca rumca modified the milestones: 1.9.6, 1.9.5 Feb 22, 2016
@rumca rumca modified the milestones: 1.9.7, 1.9.6 Apr 4, 2016
@muloem muloem modified the milestones: 1.9.7, 1.9.8 Apr 8, 2016
@janagombitova janagombitova modified the milestones: 1.9.9, 1.9.8, Priority 1 May 11, 2016
@janagombitova janagombitova changed the title Add JSX transpiler to dashboard build process Add JSX transpiler to dashboard build process (estimated: 1) May 11, 2016
@janagombitova janagombitova modified the milestone: Priority 1 Nov 2, 2016
finnfiddle added a commit that referenced this issue Mar 6, 2019
@finnfiddle
#1502 switched to webpack for admin build
4a1f9ae
finnfiddle added a commit that referenced this issue Mar 6, 2019
@finnfiddle
#1502 added eslint config
d6e4fc7
finnfiddle added a commit that referenced this issue Mar 6, 2019
@finnfiddle
#1502 switch html files to ejs
9ebb357
finnfiddle added a commit that referenced this issue Mar 6, 2019
@finnfiddle
#1502 fixed css image paths for webpack
e418640
finnfiddle added a commit that referenced this issue Mar 6, 2019
@finnfiddle
#1502 reworked imports to work with webpack
51510ce
finnfiddle added a commit that referenced this issue Mar 6, 2019
@finnfiddle
#1502 reworked view template imports for webpack
183df41
finnfiddle added a commit that referenced this issue Mar 6, 2019
@finnfiddle
#1502 syntax fixes - hoisting
a749797
finnfiddle added a commit that referenced this issue Mar 6, 2019
@finnfiddle
#1502 removed Ember.ENV.EXTEND_PROTOTYPES transform
09a4c13
@ghost ghost assigned finnfiddle Mar 6, 2019
@janagombitova
Copy link
Contributor

janagombitova commented Mar 14, 2019 •
edited
Loading

I hope this is the last issue to be found:

  • answers to repeated groups do not show in the Inspect or Monitoring tabs. The repetitions show but the answers are blank. In Maps all works fine.

Screen Shot 2019-03-14 at 16 06 09

@kymni
Copy link
Contributor

kymni commented Mar 15, 2019

@janagombitova seems the reason this particular response does not display is because the question is type option but the values submitted are free text (maybe was initially text then changed type after submitting?). Flow therefore tries to look for text property in the response but not finding it returns null hence the blank. Issue is therefore not webpack related but we still need to catch such cases

@janagombitova
Copy link
Contributor

@kymni that you for checking. Thas it very odd. I will try to reproduce it on a production instance and create a separate issue. Then all webpack issues should be handled. I did not find anything more.

finnfiddle added a commit that referenced this issue Mar 27, 2019
@finnfiddle
#1502 removed comments
739c4df
finnfiddle added a commit that referenced this issue Mar 27, 2019
@finnfiddle
#1502 webpack bundle analyzer
3576f26
finnfiddle added a commit that referenced this issue Mar 29, 2019
@finnfiddle
#1502 git version in footer
b97836d
finnfiddle added a commit that referenced this issue Mar 29, 2019
@finnfiddle
#1502 fixed webpack public config to get images loading properly
f31b152
finnfiddle added a commit that referenced this issue Mar 29, 2019
@finnfiddle
#1502 reverted jackson version
03661ab
finnfiddle added a commit that referenced this issue Mar 29, 2019
@finnfiddle
#1502 removed copying unused templates
37a9bf9
finnfiddle added a commit that referenced this issue Mar 29, 2019
@finnfiddle
Merge branch 'develop' into #1502-webpack
974e027 
* develop: (48 commits)
  [#3026]Stop updating the backend.
  [#3024] release notes
  Update bootstrap-deploy.sh
  [#3022]Avoid NPE if no user found.
  [#3018] release notes
  [#3018]Initial version of release notes.
  [#2969] Remove whitespace
  [#2971]Extract constants. Remove trailing whitespace.
  [#3017] Add NSS package
  [#3017] Add NSS package
  [#3017] Add NSS package
  [#3017] Add NSS package
  [#2970]Remove trailing whitespace.
  [#2970]Formatting...
  [#2802] unused function
  [#2802] do it the ember way
  [#2694] Remove backends configuration file
  [#2696] Refactor cascade node deletion
  [#2694] Remove backends deployment code
  [#2971]Stop calling taks on backend. Remove unused stuff.
  ...
finnfiddle added a commit that referenced this issue Mar 29, 2019
@finnfiddle
#1502 removed commented out code
1dbf7d6
muloem added a commit that referenced this issue Mar 29, 2019
@muloem
Merge pull request #3000 from akvo/#1502-webpack
e0b1a08 
[#1502] Switch UI build tools from ruby based to webpack
muloem added a commit that referenced this issue Apr 1, 2019
@muloem
[#1502] Add missing variable to generate version package
e9009f2
kymni added a commit that referenced this issue Apr 1, 2019
@kymni
Merge pull request #3037 from akvo/issue/1502-git-version
cce3c3a 
[#1502] Add missing variable to generate version package
@finnfiddle finnfiddle added this to the 1.9.45 R... R... milestone Apr 4, 2019
@finnfiddle finnfiddle reopened this Apr 4, 2019
finnfiddle added a commit that referenced this issue Apr 4, 2019
@finnfiddle
#1502 added npm install to dockerfile
0b6eb44
finnfiddle added a commit that referenced this issue Apr 4, 2019
@finnfiddle
#1502 dockerfile npm install fixes
0033509
kymni pushed a commit that referenced this issue Apr 4, 2019
[#1502] fix package.json dir
1114c36
kymni pushed a commit that referenced this issue Apr 4, 2019
[#1502] node has to be installed
83252f0
finnfiddle added a commit that referenced this issue Apr 5, 2019
@finnfiddle
#1502 added back rake build command
48ce890
kymni added a commit that referenced this issue Apr 5, 2019
@kymni
Merge pull request #3050 from akvo/issue/1502-webpack-fixes-2
cfa4003 
#1502 added back rake build command
finnfiddle added a commit that referenced this issue Apr 8, 2019
@finnfiddle
#1502 added users css file
f004ebd
finnfiddle added a commit that referenced this issue Apr 8, 2019
@finnfiddle
#1502 added script for compiling users page css
2392868
@valllllll2000
Copy link
Contributor

everything works as expected

@kymni kymni closed this as completed in 8e483c3 Apr 15, 2019
finnfiddle added a commit that referenced this issue Apr 17, 2019
@finnfiddle
Merge branch 'develop' into fix-linting-#3015
7ef1af8 
* develop: (46 commits)
  [#3069] fix tail command
  #3035 removed git hooks config
  #3035 made post merge git script silent
  #3035 remove ruby build fix
  #3035 devserver script removed typo
  capturing also the output of npm install
  #3035 made npm tasks parallel in devserver script
  #3035 removed unused file assoc. with ruby build and fixes
  [#3046] release notes update
  [#3046] release notes for 1.9.45
  remove ruby build altogether #3035
  [#3057] do not require users.scss
  [#2772]Explicit scopes. Tabs to spaces. Split long method.
  #1502 added script for compiling users page css
  #1502 added users css file
  travis slack notifications #3052
  #1502 added back rake build command
  [#1502] node has to be installed
  [#1502] fix package.json dir
  #1502 dockerfile npm install fixes
  ...

# Conflicts:
#	Dashboard/app/js/lib/main-public.js
#	Dashboard/app/js/lib/views/devices/assignments-list-view.jsx
#	Dashboard/package-lock.json
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@muloem muloem

@finnfiddle finnfiddle

Labels
Deployment & infrastructure
Projects
None yet
Milestone
1.9.45 Radiant Raspberry
Development

No branches or pull requests
6 participants
@muloem @valllllll2000 @kymni @rumca @finnfiddle @janagombitova