Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix linting #3015

Closed
finnfiddle opened this issue Mar 18, 2019 · 0 comments
Closed

fix linting #3015

finnfiddle opened this issue Mar 18, 2019 · 0 comments
Assignees
@finnfiddle

Comments

@finnfiddle
Copy link
Contributor

finnfiddle commented Mar 18, 2019 •
edited
Loading

An eslint configuration has been added as part of the webpack setup and it needs to be activated - eg. to turn on linting before committing and fixing all existing linting errors.
@finnfiddle finnfiddle self-assigned this Mar 18, 2019
finnfiddle added a commit that referenced this issue Apr 1, 2019
@finnfiddle
#3015 eslint
296f554
kymni pushed a commit that referenced this issue Apr 1, 2019
[#3015] fix for direction
f678a57
kymni pushed a commit that referenced this issue Apr 1, 2019
[#3015] fix function call
01d0a31
finnfiddle added a commit that referenced this issue Apr 17, 2019
@finnfiddle
Merge branch 'develop' into fix-linting-#3015
7ef1af8 
* develop: (46 commits)
  [#3069] fix tail command
  #3035 removed git hooks config
  #3035 made post merge git script silent
  #3035 remove ruby build fix
  #3035 devserver script removed typo
  capturing also the output of npm install
  #3035 made npm tasks parallel in devserver script
  #3035 removed unused file assoc. with ruby build and fixes
  [#3046] release notes update
  [#3046] release notes for 1.9.45
  remove ruby build altogether #3035
  [#3057] do not require users.scss
  [#2772]Explicit scopes. Tabs to spaces. Split long method.
  #1502 added script for compiling users page css
  #1502 added users css file
  travis slack notifications #3052
  #1502 added back rake build command
  [#1502] node has to be installed
  [#1502] fix package.json dir
  #1502 dockerfile npm install fixes
  ...

# Conflicts:
#	Dashboard/app/js/lib/main-public.js
#	Dashboard/app/js/lib/views/devices/assignments-list-view.jsx
#	Dashboard/package-lock.json
finnfiddle added a commit that referenced this issue Apr 17, 2019
@finnfiddle
#3015 debugging
1919535
finnfiddle added a commit that referenced this issue Apr 17, 2019
@finnfiddle
#3015 debugging
da9ac7a
finnfiddle added a commit that referenced this issue Apr 17, 2019
@finnfiddle
#3015 debugging
b773c99
finnfiddle added a commit that referenced this issue Apr 17, 2019
@finnfiddle
#3015 updated README with eslint details
7454540
finnfiddle added a commit that referenced this issue Apr 17, 2019
@finnfiddle
#3015 removed husky debug flag
d58c155
finnfiddle added a commit that referenced this issue Apr 19, 2019
@finnfiddle
removed duplicate computed prop #3015
2f2a695
muloem added a commit that referenced this issue Apr 25, 2019
@muloem
Merge pull request #3072 from akvo/issue/3015-fix-linting
74c0116 
[#3015] Add linting to repo and fix existing code issues
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@finnfiddle finnfiddle

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@finnfiddle @janagombitova