#1502 webpack (connect #1502) #3000

finnfiddle · 2019-03-07T13:14:28Z

Before the PR (what is the issue or what needed to be done)

The solution

Screenshots (if appropriate)

Checklist

* issue/1502-webpack-prod: #1502 webpack prod config [#2896] Use a fixed version number for jackson libraries [#2896] Upgrade jackson library to address further security warnings # Conflicts: # Dashboard/package-lock.json # Dashboard/package.json # Dashboard/scripts/buildDev.js # Dashboard/scripts/buildProd.js # ci/devserver.sh

…webpack * '#1502-webpack' of github.com:akvo/akvo-flow: [#1502] fix geocells.js missing variable declaration [#1502] add missing observer [#1502] remove duplicate function [#1502] fix variable declarations

GAE/pom.xml

muloem · 2019-03-29T08:35:35Z

Dashboard/.eslintrc

@@ -0,0 +1,83 @@
+{
+  "extends": "airbnb",


This is based on some styling from airbnb? I guess its relatively stable right? i.e. we wont have broken checks if airbnb decides to refurbish?

yes this is one of the most commonly used styleguides - if not THE most used. no need to worry

also the version is locked so it wont just suddenly break

muloem · 2019-03-29T08:35:56Z

Dashboard/Assetfile

@@ -17,115 +17,6 @@ class LoaderFilter < WebFilters::MinispadeFilter
  end
 end

-class EmberAssertFilter < Filter


You probably need to cleanup AssetfilePublic the same way, right?

yes youre right. we can do this at a later stage though because the hybrid build is still getting the job done as it is

Dashboard/app/js/lib/controllers/general-controllers-common.js

Dashboard/webpack.config.dev.js

* develop: (48 commits) [#3026]Stop updating the backend. [#3024] release notes Update bootstrap-deploy.sh [#3022]Avoid NPE if no user found. [#3018] release notes [#3018]Initial version of release notes. [#2969] Remove whitespace [#2971]Extract constants. Remove trailing whitespace. [#3017] Add NSS package [#3017] Add NSS package [#3017] Add NSS package [#3017] Add NSS package [#2970]Remove trailing whitespace. [#2970]Formatting... [#2802] unused function [#2802] do it the ember way [#2694] Remove backends configuration file [#2696] Refactor cascade node deletion [#2694] Remove backends deployment code [#2971]Stop calling taks on backend. Remove unused stuff. ...

finnfiddle added 15 commits March 6, 2019 14:07

#1502 switched to webpack for admin build

4a1f9ae

#1502 added eslint config

d6e4fc7

#1502 switch html files to ejs

9ebb357

#1502 fixed css image paths for webpack

e418640

#1502 reworked imports to work with webpack

51510ce

#1502 reworked view template imports for webpack

183df41

#1502 syntax fixes - hoisting

a749797

#1502 removed Ember.ENV.EXTEND_PROTOTYPES transform

09a4c13

#1502 reworked template imports for webpack 2

4e9c162

#1502 fixed syntax errors in handlebars templates

8742fdd

#1502 added missing .babelrc and removed unused steps from ruby build

3345254

#1502 reworked observers syntax to work with webpack

ecb2baf

#1502 observe mixin import fix

c26ee86

#1502 template mixin

5cfcacd

removed comments

2351f06

ghost assigned finnfiddle Mar 7, 2019

ghost added the In progress label Mar 7, 2019

finnfiddle and others added 13 commits March 8, 2019 11:06

https://github.com/akvo/akvo-flow/issues/2984

070432c

#1502 small fix webpack

65c9c41

#1502 npm install after git pull/merge

e3b0c23

#1502 webpack prod WIP

ff67b0b

#1502 webpack prod WIP

5017a5e

#1502 webpack prod config

a44ec30

reversed jackson version bump #1502

fe8825b

#1502 multiple observers same key

d784483

#1502 lint script

915ee93

#1502 optimizing eslint config + disable all errors except no-undef

1d91213

[#1502] fix variable declarations

2640161

[#1502] remove duplicate function

593a6e5

ghost assigned kymni Mar 12, 2019

kymni and others added 6 commits March 13, 2019 16:46

[#1502] add missing observer

c5e9f9d

[#1502] fix geocells.js missing variable declaration

3317a23

#1502 observer validation

50da7c2

[#1502] add observers for surveyedLocaleController

94ff23c

[#1502] clear selected surveyGroup before loading map tab

568bcc7

janagombitova changed the title ~~#1502 webpack~~ #1502 webpack (connect #1502) Mar 14, 2019

kymni requested a review from muloem March 18, 2019 08:24

janagombitova removed the In progress label Mar 25, 2019

finnfiddle added 2 commits March 27, 2019 13:58

#1502 removed comments

739c4df

#1502 webpack bundle analyzer

3576f26

muloem reviewed Mar 27, 2019

View reviewed changes

GAE/pom.xml Outdated Show resolved Hide resolved

muloem reviewed Mar 29, 2019

View reviewed changes

finnfiddle added 6 commits March 29, 2019 11:17

#1502 git version in footer

b97836d

#1502 fixed webpack public config to get images loading properly

f31b152

#1502 reverted jackson version

03661ab

#1502 removed copying unused templates

37a9bf9

#1502 removed commented out code

1dbf7d6

muloem approved these changes Mar 29, 2019

View reviewed changes

muloem merged commit e0b1a08 into develop Mar 29, 2019

muloem deleted the #1502-webpack branch March 29, 2019 10:55

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

#1502 webpack (connect #1502) #3000

#1502 webpack (connect #1502) #3000

finnfiddle commented Mar 7, 2019 •

edited

Loading

muloem Mar 29, 2019

finnfiddle Mar 29, 2019

finnfiddle Mar 29, 2019

muloem Mar 29, 2019

finnfiddle Mar 29, 2019 •

edited

Loading

#1502 webpack (connect #1502) #3000

#1502 webpack (connect #1502) #3000

Conversation

finnfiddle commented Mar 7, 2019 • edited Loading

Before the PR (what is the issue or what needed to be done)

The solution

Screenshots (if appropriate)

Checklist

muloem Mar 29, 2019

Choose a reason for hiding this comment

finnfiddle Mar 29, 2019

Choose a reason for hiding this comment

finnfiddle Mar 29, 2019

Choose a reason for hiding this comment

muloem Mar 29, 2019

Choose a reason for hiding this comment

finnfiddle Mar 29, 2019 • edited Loading

Choose a reason for hiding this comment

finnfiddle commented Mar 7, 2019 •

edited

Loading

finnfiddle Mar 29, 2019 •

edited

Loading