Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#1502] Add missing variable to generate version package #3037

Merged
merged 1 commit into from
Apr 1, 2019

Conversation

muloem
Copy link
Member

@muloem muloem commented Apr 1, 2019

Before the PR (what is the issue or what needed to be done)

  • The version (zip) package used for deployment was not being generated, which means deployments would not work because the set of files for that version would not be found on the remove bucket.

The solution

  • Correctly generate version package with the git tag.

Screenshots (if appropriate)

Checklist

  • Connect the issue
  • Test plan
  • Copyright header
  • Code formatting
  • Documentation

@muloem muloem requested a review from kymni April 1, 2019 10:00
@kymni kymni merged commit cce3c3a into develop Apr 1, 2019
@kymni kymni deleted the issue/1502-git-version branch April 1, 2019 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants