Implement file uploads #51
Comments
|
Why doesn't the build look like that? |
|
Where in the build is this functionality? Because it doesn't look like the one in the image |
|
It looks like that in https://github.com/commaai/connect, the task is to create a replacement for new-connect |
The demo from https://connect.comma.ai/1d3dc3e03047b0c7/000000dd--455f14369d shows device offline, and didn't show upload. How can I know what to fix for this ticket?
|
|
Hey! Could you clarify what you mean by a table of segments? Are you referring to a structured representation of the routes, along with the different file types available for download? @incognitojam @adeebshihadeh |
|
@mfeinLearn I believe that they want a organized grid like layout so you can upload specific parts of segments biased on their types of engagements and file types? Kind of like a file gallery. |
last part of #51 handles device disconnected, no items in queue, and rendering a list of files being uploaded possible features to add in the future: - nice animations - displaying the offline queue - simplify the polling loop with something like https://tanstack.com/query/latest/docs/framework/solid/overview
|
spoke on discord with @incognitojam, implementing the offline queue will complete the requirements of this issue |
|
Locked to @greatgitsby (should have done this sooner) |
#51 tested locally: 1. when device offline, upload request puts items in offline queue, showing them in the queue in the UI with a "Queued" message 2. when device comes online, status switches to "Waiting" until Athena server pushes the queued requests 3. finally, messages start coming in and processing as normal
This is what connect looks like currently:
Instead, I think we want a table of segments and all the file types: qlog, qcam, rlog, fcam, etc.
Either need a comma 3/3X to test this, or jury-rig connect to talk to an athena instance on your PC.
Requirements:
Upload files for segment@incognitojam working on itThe text was updated successfully, but these errors were encountered: