Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: upload queue #251

Merged
merged 17 commits into from
Mar 27, 2025
Merged

feat: upload queue #251

merged 17 commits into from
Mar 27, 2025

Conversation

greatgitsby
Copy link
Contributor

@greatgitsby greatgitsby commented Mar 27, 2025 •
edited
Loading

last part of #51

handles device disconnected, no items in queue, and rendering a list of files being uploaded

possible features to add in the future:

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 27, 2025 •
edited
Loading

Changes:

path lines diff
./components/UploadQueue.tsx 97 +97
./pages/dashboard/activities/DeviceActivity.tsx 160 +16

Total lines: 4160 (+113)

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 27, 2025 •
edited
Loading

deployed preview: https://251.connect-d5y.pages.dev

Welcome to connect! Make sure to:

  • read the contributing guidelines
  • mark your PR as a draft until it's ready to review
  • post the preview on Discord; feedback from users will speedup the PR review

Mobile

Desktop

@greatgitsby greatgitsby mentioned this pull request Mar 27, 2025
Closed
@greatgitsby greatgitsby marked this pull request as ready for review March 27, 2025 04:15
incognitojam
incognitojam requested changes Mar 27, 2025
View reviewed changes
Copy link
Member

@incognitojam incognitojam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and it's tiny now 🙂 Just small things to change

@incognitojam incognitojam added the enhancement new feature or request label Mar 27, 2025
@incognitojam incognitojam merged commit 4162d88 into commaai:master Mar 27, 2025
7 checks passed
@greatgitsby greatgitsby deleted the feat/upload-queue-lite branch March 29, 2025 23:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@incognitojam incognitojam incognitojam approved these changes

Assignees
No one assigned
Labels
enhancement new feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@greatgitsby @incognitojam