feat: upload user files #216
Conversation
deployed preview: https://216.connect-d5y.pages.devWelcome to connect! Make sure to:
Mobile
Desktop
|
greatgitsby
force-pushed
the
feat/upload-apis
branch
from
4eeb57c to
30aef77
Compare
greatgitsby
changed the title
|
we should have a backlog item for defining style in Biome to ensure things like line wrapping and quotes are consistent not super big deal, but it'll help avoid you having to make small nit commits on everyone's PRs 😄 |
|
Not counting blank lines in the lint count means we don't need to be super aggressive anymore 🙂 |
There was a problem hiding this comment.
We should have the "upload all segments" button in this PR so that is isn't just adding unused code 😄
This PR stills adds lots of methods and types for the upload queue. Normally I would try to split PRs along the line of features rather than "backend" and UI like this, but I'm fine with leaving this stuff here in this case if you want to
The next PR should add the upload queue
|
sounds great! |
greatgitsby
changed the title
Co-authored-by: Cameron Clough <[email protected]>
| const fileTypesToUpload = buttonToFileTypeMap[type] | ||
|
|
||
| try { | ||
| await uploadAllSegments(props.routeName, route.segment_numbers.length, fileTypesToUpload) |
There was a problem hiding this comment.
We only added routes_segments to get maxqlog? We're trying to deprecate it
There was a problem hiding this comment.
is this written in documentation somewhere?
There was a problem hiding this comment.
happy to change it
There was a problem hiding this comment.
d["segment_numbers"] = list(range(0, r.maxqlog+1))
we can just use this
There was a problem hiding this comment.
i'll patch this
Added in #216 from `routes_segments` API: ``` for row in q.all(): d["start_time_utc_millis"] = int((0 if r.start_time is None else r.start_time.timestamp()) * 1000) d["end_time_utc_millis"] = int((0 if r.end_time is None else r.end_time.timestamp()) * 1000) # TODO: remove these once connect doesn't use them d["segment_numbers"] = list(range(0, r.maxqlog+1)) d["segment_start_times"] = [d["start_time_utc_millis"]+(i*60*1000) for i in range(r.maxqlog+1)] d["segment_end_times"] = [min(d["segment_start_times"][i]+(60*1000), d["end_time_utc_millis"]) for i in range(r.maxqlog+1)] res[r.fullname] = d return jsonify(list(res.values())) ```
closes #51
keeping in mind the LoC limits, minimized some lines in nearby APIs