Issue/3015 fix linting #3072
Merged
Issue/3015 fix linting #3072
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* develop: (46 commits) [#3069] fix tail command #3035 removed git hooks config #3035 made post merge git script silent #3035 remove ruby build fix #3035 devserver script removed typo capturing also the output of npm install #3035 made npm tasks parallel in devserver script #3035 removed unused file assoc. with ruby build and fixes [#3046] release notes update [#3046] release notes for 1.9.45 remove ruby build altogether #3035 [#3057] do not require users.scss [#2772]Explicit scopes. Tabs to spaces. Split long method. #1502 added script for compiling users page css #1502 added users css file travis slack notifications #3052 #1502 added back rake build command [#1502] node has to be installed [#1502] fix package.json dir #1502 dockerfile npm install fixes ... # Conflicts: # Dashboard/app/js/lib/main-public.js # Dashboard/app/js/lib/views/devices/assignments-list-view.jsx # Dashboard/package-lock.json
muloem
reviewed
Apr 18, 2019
muloem
reviewed
Apr 19, 2019
muloem
approved these changes
Apr 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before the PR (what is the issue or what needed to be done)
Client-side code was not being linted - ie no styleguide enforced, syntax errors slipping through.
The solution
Enforce eslint in the build and in a pre-commit git hook.
Screenshots (if appropriate)
Checklist