Issue/3115 publish form using jackson (Connect #3115) #3220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…for that. Start on XML generation. Add a test class for that.
stellanl
requested review from
valllllll2000 and
muloem
and removed request for
valllllll2000
muloem
reviewed
Oct 18, 2019
… 'survey' where appropriate.
muloem
requested changes
Oct 24, 2019
GAE/src/org/waterforpeople/mapping/app/web/SurveyAssemblyServlet.java
Outdated
Show resolved
Hide resolved
GAE/src/org/waterforpeople/mapping/app/web/SurveyAssemblyServlet.java
Outdated
Show resolved
Hide resolved
…ower log level. Use equals() instead of ==.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before the PR (what is the issue or what needed to be done)
XML for the app was generated by a lot of ad-hoc Java code.
The solution
Use the Jackson XML library to do it with the same classes used to parse app XML. Write tests for the result.
Screenshots (if appropriate)
Checklist