Use parameterized names in dynamic query #399
Conversation
| @@ -737,6 +737,8 @@ Expression ParseUnary() | |||
| Expression ParsePrimary() | |||
| { | |||
| Expression expr = ParsePrimaryStart(); | |||
| _expressionHelper.WrapConstantExpression(ref expr); | |||
There was a problem hiding this comment.
@StefH This is the principal change here. I'll let you determine if this makes sense to fix the issue in this way or not.
|
|
||
| [Theory] | ||
| [InlineData("NullableIntValue", "42")] | ||
| [InlineData("NullableDoubleValue", "42.23")] |
There was a problem hiding this comment.
NullableDoubleValue is the test case for the issue in #331 (comment)
|
@JonathanMagnan any updates on this? Would love to see this merged (or rejected, if that's the right answer). |
|
Hello @ascott18 , Sorry for the delay, I'm currently looking at it. There is currently some weird stuff such as why a I'm not sure either if this line https://github.com/zzzprojects/System.Linq.Dynamic.Core/pull/399/files#diff-e02763e459f8622732aa03abaf297810R740 should really exists in the I will continue to look at it and keep you updated later this week. |
Fix unit test project caused by pull #399 and allow parse double
|
Hello @ascott18 , Your pull has been merged in the v1.2.1 Thank a lot for your help and your follow-up ;) Best Regards, Jon |
Builds on #331 - added wrapping of constants as soon as they're parsed to avoid cases where they can slip through the cracks.