Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ConstantExpressionWrapper to support Nullable (wip...) #332

Closed
wants to merge 1 commit into from

Conversation

StefH
Copy link
Collaborator

@StefH StefH commented Dec 11, 2019

@StefH StefH added the bug label Dec 11, 2019
@StefH StefH self-assigned this Dec 11, 2019
@codecov
Copy link

codecov bot commented Dec 11, 2019

Codecov Report

Merging #332 into master will decrease coverage by 1.19%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #332      +/-   ##
==========================================
- Coverage   88.22%   87.02%   -1.20%     
==========================================
  Files          45       45              
  Lines        4491     4571      +80     
==========================================
+ Hits         3962     3978      +16     
- Misses        529      593      +64     

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 57ce8f7...7991751. Read the comment docs.

@StefH
Copy link
Collaborator Author

StefH commented Jan 4, 2020

#331

@StefH StefH changed the title Fix ConstantExpressionWrapper to support Nullable Fix ConstantExpressionWrapper to support Nullable (wip...) Mar 18, 2020
@ascott18
Copy link
Contributor

@StefH What is the status on this? What remains to be done - anything that someone could help out with?

@StefH
Copy link
Collaborator Author

StefH commented Jul 10, 2020

@ascott18
I could use some help indeed.

See issue #331 which defines another scenario which seems to be not handled correctly by the code.

@ascott18
Copy link
Contributor

I'll take a look and see what I can figure out.

@ascott18
Copy link
Contributor

@StefH Opened #399 that builds on this PR to fix that issue in #331.

@JonathanMagnan
Copy link
Member

Close this PR as requested by StefH, we will work instead using the pull #399

@StefH StefH deleted the UseParameterizedNamesInDynamicQuery branch August 1, 2021 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

3 participants