[Work In Progress] Implement generic handling of method invocation #295
Conversation
|
There are some merge conflicts. Can you fix these.? |
| @@ -5,7 +5,7 @@ namespace System.Reflection | |||
| /// <summary> | |||
| /// https://github.com/castleproject/Core/blob/netcore/src/Castle.Core/Compatibility/IntrospectionExtensions.cs | |||
| /// </summary> | |||
| internal static class CustomIntrospectionExtensions | |||
| public static class CustomIntrospectionExtensions | |||
| using System; | ||
| using System.Linq.Expressions; | ||
|
|
||
| namespace ETG.SABENTISpro.Utils.DynamicLinkCore.Compatibility |
There was a problem hiding this comment.
If you merge master into your branch, you get this code. So this class can be removed.
| @@ -10,6 +10,8 @@ namespace System.Linq.Dynamic.Core.CustomTypeProviders | |||
| /// </summary> | |||
| public abstract class AbstractDynamicLinqCustomTypeProvider | |||
| { | |||
|
|
|||
| @@ -23,6 +23,17 @@ public string GetDisplayName(bool a, bool b, bool c) | |||
|
|
|||
| class C : AbstractDynamicLinqCustomTypeProvider, IDynamicLinkCustomTypeProvider | |||
| { | |||
| /// <inheritdoc cref="IDynamicLinkCustomTypeProvider"/> | |||
| public List<Type> GetMethodIntrospectionTypes() | |||
There was a problem hiding this comment.
Why not define these hard-coded in the code and let the user add more if needed?
like public List<Type> AdditionalMethodIntrospectionTypes() ?
|
|
||
| if (ce != null) | ||
| // TODO: Recode to handle N possible arguments |
There was a problem hiding this comment.
For a quick solution, just add a private helper method which handles up to 10 arguments.
| @@ -84,13 +123,20 @@ public virtual Expression Promote(Expression expr, Type type, bool exact, bool c | |||
| } | |||
| } | |||
| } | |||
|
|
|||
| // Try to autopromote string to guid, because in Json and other serializations guid | |||
There was a problem hiding this comment.
There are several places where some exceptions are made for Guid's.
Maybe remove this code here, and make a new PR to fix/update the handling of guids?
| @@ -253,14 +335,14 @@ public static bool IsNumericType(Type type) | |||
| return GetNumericTypeKind(type) != 0; | |||
| } | |||
|
|
|||
| public static bool IsNullableType(Type type) | |||
| public static bool IsNullableType(this Type type) | |||
There was a problem hiding this comment.
Can you please keep all methods in this class as normal methods? (Not extension methods.)
|
@david-garcia-garcia Other question, maybe if you have time, can you also quickly look at this #286 ? |
|
Closing this PR for now since it's been some time since this was active. |
No description provided.