Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not generate IIF(...) when np(...) is used for a single expression #286

Merged
merged 2 commits into from
Nov 26, 2019
Merged

Do not generate IIF(...) when np(...) is used for a single expression #286

merged 2 commits into from
Nov 26, 2019

Conversation

StefH
Copy link
Collaborator

@StefH StefH commented Aug 10, 2019

No description provided.

@StefH StefH added the feature label Aug 10, 2019
@codecov
Copy link

codecov bot commented Aug 10, 2019 •
edited
Loading

Codecov Report

Merging #286 into master will increase coverage by 0.16%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #286      +/-   ##
=========================================
+ Coverage   87.04%   87.2%   +0.16%     
=========================================
  Files          42      42              
  Lines        4260    4267       +7     
=========================================
+ Hits         3708    3721      +13     
+ Misses        552     546       -6
Impacted Files Coverage Δ
...ystem.Linq.Dynamic.Core/Parser/ExpressionParser.cs 85.65% <100%> (+0.05%) ⬆️
...ystem.Linq.Dynamic.Core/Parser/ExpressionHelper.cs 95.14% <100%> (+1.02%) ⬆️
...rc/System.Linq.Dynamic.Core/DynamicClassFactory.cs 98.63% <0%> (+1.81%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fe440b6...465d1f6. Read the comment docs.

4 similar comments
@codecov
Copy link

codecov bot commented Aug 10, 2019

Codecov Report

Merging #286 into master will increase coverage by 0.16%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #286      +/-   ##
=========================================
+ Coverage   87.04%   87.2%   +0.16%     
=========================================
  Files          42      42              
  Lines        4260    4267       +7     
=========================================
+ Hits         3708    3721      +13     
+ Misses        552     546       -6
Impacted Files Coverage Δ
...ystem.Linq.Dynamic.Core/Parser/ExpressionParser.cs 85.65% <100%> (+0.05%) ⬆️
...ystem.Linq.Dynamic.Core/Parser/ExpressionHelper.cs 95.14% <100%> (+1.02%) ⬆️
...rc/System.Linq.Dynamic.Core/DynamicClassFactory.cs 98.63% <0%> (+1.81%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fe440b6...465d1f6. Read the comment docs.

@codecov
Copy link

codecov bot commented Aug 10, 2019 •
edited
Loading

Codecov Report

Merging #286 into master will increase coverage by 0.16%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #286      +/-   ##
=========================================
+ Coverage   87.04%   87.2%   +0.16%     
=========================================
  Files          42      42              
  Lines        4260    4267       +7     
=========================================
+ Hits         3708    3721      +13     
+ Misses        552     546       -6
Impacted Files Coverage Δ
...ystem.Linq.Dynamic.Core/Parser/ExpressionParser.cs 85.65% <100%> (+0.05%) ⬆️
...ystem.Linq.Dynamic.Core/Parser/ExpressionHelper.cs 95.14% <100%> (+1.02%) ⬆️
...rc/System.Linq.Dynamic.Core/DynamicClassFactory.cs 98.63% <0%> (+1.81%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fe440b6...465d1f6. Read the comment docs.

@codecov
Copy link

codecov bot commented Aug 10, 2019 •
edited
Loading

Codecov Report

Merging #286 into master will increase coverage by 0.16%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #286      +/-   ##
=========================================
+ Coverage   87.04%   87.2%   +0.16%     
=========================================
  Files          42      42              
  Lines        4260    4267       +7     
=========================================
+ Hits         3708    3721      +13     
+ Misses        552     546       -6
Impacted Files Coverage Δ
...ystem.Linq.Dynamic.Core/Parser/ExpressionParser.cs 85.65% <100%> (+0.05%) ⬆️
...ystem.Linq.Dynamic.Core/Parser/ExpressionHelper.cs 95.14% <100%> (+1.02%) ⬆️
...rc/System.Linq.Dynamic.Core/DynamicClassFactory.cs 98.63% <0%> (+1.81%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fe440b6...465d1f6. Read the comment docs.

@codecov
Copy link

codecov bot commented Aug 10, 2019

Codecov Report

Merging #286 into master will increase coverage by 0.16%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #286      +/-   ##
=========================================
+ Coverage   87.04%   87.2%   +0.16%     
=========================================
  Files          42      42              
  Lines        4260    4267       +7     
=========================================
+ Hits         3708    3721      +13     
+ Misses        552     546       -6
Impacted Files Coverage Δ
...ystem.Linq.Dynamic.Core/Parser/ExpressionParser.cs 85.65% <100%> (+0.05%) ⬆️
...ystem.Linq.Dynamic.Core/Parser/ExpressionHelper.cs 95.14% <100%> (+1.02%) ⬆️
...rc/System.Linq.Dynamic.Core/DynamicClassFactory.cs 98.63% <0%> (+1.81%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fe440b6...465d1f6. Read the comment docs.

@codecov
Copy link

codecov bot commented Aug 10, 2019 •
edited
Loading

Codecov Report

Merging #286 into master will increase coverage by 0.16%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #286      +/-   ##
=========================================
+ Coverage   87.04%   87.2%   +0.16%     
=========================================
  Files          42      42              
  Lines        4260    4267       +7     
=========================================
+ Hits         3708    3721      +13     
+ Misses        552     546       -6
Impacted Files Coverage Δ
...ystem.Linq.Dynamic.Core/Parser/ExpressionParser.cs 85.65% <100%> (+0.05%) ⬆️
...ystem.Linq.Dynamic.Core/Parser/ExpressionHelper.cs 95.14% <100%> (+1.02%) ⬆️
...rc/System.Linq.Dynamic.Core/DynamicClassFactory.cs 98.63% <0%> (+1.81%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fe440b6...85d6636. Read the comment docs.

@StefH StefH mentioned this pull request Sep 1, 2019
Closed
@StefH StefH merged commit e58e1e0 into master Nov 26, 2019
@StefH StefH deleted the np_fix branch November 26, 2019 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
feature
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@StefH