-
-
Notifications
You must be signed in to change notification settings - Fork 231
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix the problem with inner double quotes #195
Merged
Merged
Changes from 1 commit
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
eca21da
Fix for ParseLambda with itType and resultType: correct order of argu…
4b7d15a
Add references for missing classes
cd4b420
Fix for missing classes: UserState and UserProfileDetails
c7d29f4
Small update on unit-test (no need to check for `DoesNotThrow`)
StefH e6ddce6
add comment to appveyor
StefH 9a5e5e3
Only run SonarScanner on master branch
StefH 02bda33
APPVEYOR_REPO_BRANCH
StefH e77c116
APPVEYOR_PULL_REQUEST_NUMBER
StefH d7d432b
No working unit test for inner double quotes
2c840f8
Fix for inner double quotes
8590347
Merge branch 'master' into pull-requests-branch
OlegNadymov e13c9d1
Using {}
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -755,6 +755,16 @@ Expression ParseStringLiteral() | |
_textParser.ValidateToken(TokenId.StringLiteral); | ||
char quote = _textParser.CurrentToken.Text[0]; | ||
string s = _textParser.CurrentToken.Text.Substring(1, _textParser.CurrentToken.Text.Length - 2); | ||
int index1 = 0; | ||
while (true) | ||
{ | ||
int index2 = s.IndexOf(quote, index1); | ||
if (index2 < 0) | ||
break; | ||
if (index2 + 1 < s.Length && s[index2 + 1] == quote) | ||
s = s.Remove(index2, 1); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Please use {} in this new code. Example: if (index2 < 0)
{
break;
} There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @StefH Ok! It was done. |
||
index1 = index2 + 1; | ||
} | ||
|
||
if (quote == '\'') | ||
{ | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please use {} in this new code. Example:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok! I'm done.