-
-
Notifications
You must be signed in to change notification settings - Fork 231
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix the problem with inner double quotes #195
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are some merge conflicts, please merge main into this branch and fix merge conflicts.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small updates in code.
while (true) | ||
{ | ||
int index2 = s.IndexOf(quote, index1); | ||
if (index2 < 0) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please use {} in this new code. Example:
if (index2 < 0)
{
break;
}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok! I'm done.
if (index2 < 0) | ||
break; | ||
if (index2 + 1 < s.Length && s[index2 + 1] == quote) | ||
s = s.Remove(index2, 1); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please use {} in this new code. Example:
if (index2 < 0)
{
break;
}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@StefH Ok! It was done.
Codecov Report
@@ Coverage Diff @@
## master #195 +/- ##
==========================================
+ Coverage 82.61% 82.86% +0.25%
==========================================
Files 37 37
Lines 3658 3671 +13
Branches 493 495 +2
==========================================
+ Hits 3022 3042 +20
Misses 498 498
+ Partials 138 131 -7
Continue to review full report at Codecov.
|
@StefH I made the required changes in the code. Something else needs to be done? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@StefH, all required changes were done
Thanks a lot. A small question, how does the code behave if you use something like an incomplete escaped string as a search query? |
@StefH I've just tried it. And it works is like before. It throws |
@StefH may be you skipped my comment about new code. |
Ok. I will merge the code soon. |
@StefH ok! Thank you! And update nuget please. |
@StefH did you update nuget? |
Not yet sorry. Tomorrow morning. |
NuGets uploaded |
@StefH thank you!! |
Do I correct create expression for my case with inner double quotes?
After move from System.Dynamic.Linq to System.Dynamic.Linq.Core all my similar expressions were broken