-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
2617/2658 Fix Change account is slow & User can claim subdomain again #2654
Merged
Doublemme
merged 11 commits into
main
from
2617-change-account-slow-form-wallet-management
Feb 11, 2025
Merged
2617/2658 Fix Change account is slow & User can claim subdomain again #2654
Doublemme
merged 11 commits into
main
from
2617-change-account-slow-form-wallet-management
Feb 11, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jest ReportSummary
Tests
Coverage (92%)
|
hughlivingstone
approved these changes
Feb 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
Closes #2617
Closes #2658
Description of Changes
When the NFT page is loaded, changing account from one to another in Wallet management screen it's little bit laggy since the app need to reload the NFTs for the new account, reduced the amount of API requests for getting vetDomains and optimize the calculation if a single account can claim or not the vet domain
Also I fixed a bug with the blurred backdrop that do not allow the user to close it clicking on it.
Reviewer(s)
@mfrezzati
Checklist
Thank you for contributing! 🎉