-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test: fix tests skipping notification modal at startup #2624
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jest ReportSummary
Tests
Coverage (92%)
|
paolampilla
approved these changes
Feb 5, 2025
Jonathansoufer
pushed a commit
that referenced
this pull request
Feb 6, 2025
* test: fix tests skipping notification bottom sheet * test: fix file not found for skip notification flow * test: removed helper flow * test: updated setup flow for e2e * test: add skip notification flow to contact flow * fix: android notification modal tests --------- Co-authored-by: Michael Martin <[email protected]> Co-authored-by: paolampilla <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
Since we activate the Push Notification feature in the app now on iOS we have to skip the modal that pops up asking to enable the notifications otherwise tests fails
Reviewer(s)
@grenos @mfrezzati
Thank you for contributing! 🎉