-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add LOWER case as default for copyable addresses #2565
Conversation
Jest ReportSummary
Tests
Coverage (92%)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Additional Notes
Recommendation: Consider using lowercase since Ethereum addresses are case-insensitive, and lowercase is commonly used in blockchain applications for readability.
Seb suggested to standardize everything on lower case to be more compliant with Ethereum why did you choose to go with the upper case?
Related Issue
Closes #2524
Description of Changes
This PR adds a LOWER case functionality on account address copyable component. This is necessary to provide the same result on both extension and mobile when user's copy their address. No UI change is necessary.
Reviewer(s)
@grenos @Doublemme @mfrezzati
UI/UX Changes
Checklist
Thank you for contributing! 🎉