-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
2534 v 2078 bug ticket #2538
2534 v 2078 bug ticket #2538
Conversation
Jest ReportSummary
Tests
Coverage (92%)
|
src/Screens/Flows/App/HomeScreen/Components/AccountCard/AccountFiatBalance.tsx
Outdated
Show resolved
Hide resolved
src/Screens/Flows/App/HomeScreen/Components/ListsView/Token/VeB3trTokenCard.tsx
Outdated
Show resolved
Hide resolved
src/Screens/Flows/App/HomeScreen/Components/ListsView/Token/TokenList.tsx
Show resolved
Hide resolved
@@ -90,19 +90,19 @@ export const TokenList = memo(({ isBalanceVisible, ...animatedViewProps }: Props | |||
return ( | |||
<Animated.View {...animatedViewProps}> | |||
<AnimatedTokenListItem | |||
isVechainToken | |||
isVechainToken={true} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not need to declare true, if you provide the props is already true
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
in this case it's needed because it's a discriminated union, setting to true is telling what set of props the component should accept. At runtime it would work but for development typescript has an issue with it
Related Issue
Closes #2534
Description of Changes
Reviewer(s)
@Doublemme
UI/UX Changes
VOT3/B3TR card fiat balance
Account card fiat balance
Loading Skeleton color on account card
Graph color dark mode
Button inactive state
testnet browser icon color
Discovery page history icon color
Insufficient VTHO warning
Checklist
Thank you for contributing! 🎉