Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2534 v 2078 bug ticket #2538

Merged
merged 8 commits into from
Jan 16, 2025
Merged

2534 v 2078 bug ticket #2538

merged 8 commits into from
Jan 16, 2025

Conversation

paolampilla
Copy link
Contributor

@paolampilla paolampilla commented Jan 16, 2025

Related Issue

Closes #2534

Description of Changes

  • VOT3/B3TR card - fiat conversion only works when an account has B3TR. When an account has B3TR & VOT3 or just VOT3, the token card is always 0 $/€
  • Account card - when an account has VOT3 the account card shows 0 €/$
  • Graph - in dark mode, the graph is all purple, so it's difficult to see. Perhaps as a short term fix, we have a white colour for the chart line.
  • Button in inactive state is transparent.
  • testnet browser - white buttons in light mode.
  • Discovery page - history is incorrect colour.
  • Insufficient VTHO warning in dark - I understand in wrong colour.
  • Loading skeleton from balance in Account Card was the wrong color

Reviewer(s)

@Doublemme

UI/UX Changes

VOT3/B3TR card fiat balance

Screenshot 2025-01-16 at 04 58 41

Account card fiat balance

Screenshot 2025-01-16 at 05 15 04

Loading Skeleton color on account card

Screenshot 2025-01-16 at 05 19 47

Graph color dark mode

Screenshot 2025-01-16 at 04 59 44

Button inactive state

Screenshot 2025-01-16 at 05 01 51

testnet browser icon color

Screenshot 2025-01-16 at 05 09 49

Discovery page history icon color

Screenshot 2025-01-16 at 05 11 16

Insufficient VTHO warning

Screenshot 2025-01-16 at 05 03 03 Screenshot 2025-01-16 at 05 13 25

Checklist

  • Code adheres to project guidelines and conventions.
  • Unit tests, if applicable, are updated and passing.
  • Documentation, if applicable, has been updated.
  • UI/UX changes include visuals (video or screenshots).

Thank you for contributing! 🎉

@paolampilla paolampilla linked an issue Jan 16, 2025 that may be closed by this pull request
13 tasks
@paolampilla paolampilla marked this pull request as ready for review January 16, 2025 08:24
Copy link

github-actions bot commented Jan 16, 2025

Jest Report

Summary

Lines Statements Branches Functions
Coverage: 92%
92.99% (1753/1885) 85.34% (530/621) 95.87% (302/315)

Tests

Tests Skipped Failures Errors Time
872 0 💤 0 ❌ 0 🔥 13m 46s ⏱️
Coverage (92%)
File% Stmts% Branch% Funcs% LinesUncovered Line #s
All files92.9985.3495.8792.75 
AccountUtils100100100100 
   AccountUtils.ts100100100100 
ActivityUtils100100100100 
   ActivityUtils.ts100100100100 
AddressUtils100100100100 
   AddressUtils.ts100100100100 
AlertUtils10010080100 
   Alert.ts10010080100 
ArrayUtils100100100100 
   ArrayUtils.ts100100100100 
BalanceUtils97.878010097.61 
   BalanceUtils.ts97.878010097.6178
BigNumberUtils10097.22100100 
   BigNumberUtils.ts10097.22100100184
BiometricsUtils95.389591.6696.29 
   BiometricErrors.ts88.8891.668091.354–55
   Biometrics.ts100100100100 
BloomUtils100100100100 
   BloomUtils.ts100100100100 
CacheKeyUtils100100100100 
   CacheKeyUtils.ts100100100100 
ColorUtils100100100100 
   ColorUtils.ts100100100100 
CryptoUtils96.5978.5710097.56 
   CryptoUtils.ts96.5978.5710097.5650, 68
CryptoUtils/Helpers76.3458.6288.8876.34 
   fastKeystoreDecrypt.ts76.3458.6288.8876.3433, 53, 69, 75, 80, 104, 110, 126, 138–162
CryptoUtils_Legacy100100100100 
   CryptoUtils_Legacy.ts100100100100 
CryptoUtils_Legacy/Helpers76.3458.6288.8876.34 
   fastKeystoreDecrypt.ts76.3458.6288.8876.3433, 53, 69, 75, 80, 104, 110, 126, 138–162
DAppUtils63.1552.837561.81 
   DAppUtils.ts63.1552.837561.8158, 65–116
DateUtils100100100100 
   DateUtils.ts100100100100 
DeviceUtils100100100100 
   DeviceUtils.ts100100100100 
ErrorMessageUtils100100100100 
   ErrorMessageUtils.ts100100100100 
FormUtils100100100100 
   FormUtils.ts100100100100 
FormattingUtils96.8791.66100100 
   FormattingUtils.ts96.8791.6610010026
GasUtils93.0573.810094.11 
   GasUtils.ts93.0573.810094.1152, 202–206
HexUtils94.2875100100 
   HexUtils.ts94.287510010063–65
IPFSUtils100100100100 
   IPFSUtils.ts100100100100 
LedgerUtils75.2491.6683.3373.95 
   LedgerUtils.ts75.2491.6683.3373.9583–87, 125–150, 179–184, 229–237, 294, 313–314
LocaleUtils10050100100 
   LocaleUtils.ts100501001006
LockScreenUtils100100100100 
   LockScreenUtils.ts100100100100 
Logger958010095 
   Logger.ts95801009538
MathUtils100100100100 
   MathUtils.ts100100100100 
MediaUtils10095.65100100 
   MediaUtils.ts10095.6510010078
MergeUtils100100100100 
   MergeUtils.ts100100100100 
PasswordUtils76.19505075 
   PasswordUtils.ts76.1950507563–64, 68, 72–73
PicassoUtils100100100100 
   PicassoUtils.ts100100100100 
PlatformUtils100100100100 
   PlatformUtils.ts100100100100 
ReanimatedUtils91.8973.3310093.93 
   Reanimated.ts91.8973.3310093.9351, 63
SemanticVersionUtils100100100100 
   SemanticVersionUtils.ts100100100100 
SignMessageUtils100100100100 
   SignMessageUtils.ts100100100100 
StringUtils100100100100 
   StringUtils.ts100100100100 
TokenUtils100100100100 
   TokenUtils.ts100100100100 
TransactionUtils97.2692.197.2997.64 
   TransactionUtils.ts97.2692.197.2997.64706–712, 802–806
TransfersUtils10080100100 
   TransfersUtils.ts10080100100100
URIUtils100100100100 
   URIUtils.ts100100100100 
WalletConnectUtils89.990.988.2390.29 
   WalletConnectUtils.tsx89.990.988.2390.2924–47

@@ -90,19 +90,19 @@ export const TokenList = memo(({ isBalanceVisible, ...animatedViewProps }: Props
return (
<Animated.View {...animatedViewProps}>
<AnimatedTokenListItem
isVechainToken
isVechainToken={true}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not need to declare true, if you provide the props is already true

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in this case it's needed because it's a discriminated union, setting to true is telling what set of props the component should accept. At runtime it would work but for development typescript has an issue with it

@paolampilla paolampilla merged commit 988a214 into main Jan 16, 2025
9 of 11 checks passed
@paolampilla paolampilla deleted the 2534-v-2078---bug-ticket branch January 16, 2025 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

V 2.0.7/8 - Bug ticket
2 participants