Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2463 Fix toast notification addresses #2464

Merged
merged 2 commits into from
Dec 4, 2024
Merged

Conversation

Doublemme
Copy link
Collaborator

@Doublemme Doublemme commented Dec 3, 2024

Related Issue

Closes #2463

Description of Changes

Fixed the parsing of the addresses and the vet domains

Reviewer(s)

@grenos @mfrezzati

UI/UX Changes

Sending from account not in VeWorld

Simulator.Screen.Recording.-.iPhone.15.Pro.Max.-.2024-12-03.at.10.14.29.mp4

Sending to an account in VeWorld

Simulator.Screen.Recording.-.iPhone.15.Pro.Max.-.2024-12-03.at.10.12.19.mp4

Checklist

  • Code adheres to project guidelines and conventions.
  • Unit tests, if applicable, are updated and passing.
  • Documentation, if applicable, has been updated.
  • UI/UX changes include visuals (video or screenshots).

Thank you for contributing! 🎉

Copy link

socket-security bot commented Dec 3, 2024

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@babel/[email protected] None 0 546 kB existentialism, hzoo, jlhwung, ...1 more
npm/@babel/[email protected] None 0 11.5 kB existentialism, hzoo, jlhwung, ...1 more
npm/@babel/[email protected] None +1 203 kB existentialism, hzoo, jlhwung, ...1 more
npm/@babel/[email protected] None 0 137 kB existentialism, hzoo, jlhwung, ...1 more
npm/@babel/[email protected] None 0 681 kB nicolo-ribaudo
npm/@babel/[email protected] None 0 2.55 MB existentialism, hzoo, jlhwung, ...1 more
npm/@expo/[email protected] Transitive: environment, filesystem +3 893 kB alanhughes, aleqsio, betoatexpo, ...24 more
npm/@sentry/[email protected] None 0 1.56 MB sentry-bot
npm/@tanstack/[email protected] environment 0 1.85 MB nksaraf, tannerlinsley
npm/@tanstack/[email protected] environment 0 135 kB tannerlinsley
npm/@tanstack/[email protected] None 0 38.4 kB nksaraf, tannerlinsley
npm/@tanstack/[email protected] None 0 31.5 kB tannerlinsley
npm/@tanstack/[email protected] environment 0 704 kB nksaraf, tannerlinsley
npm/@types/[email protected] None 0 439 kB types
npm/[email protected] None 0 1.17 MB awkweb
npm/[email protected] None 0 2.14 MB ai, beneb, caniuse-lite
npm/[email protected] None 0 153 kB kilianvalkhof
npm/[email protected] None +1 60.9 kB tootallnate
npm/[email protected] None 0 23.4 kB ljharb
npm/[email protected] None 0 17.9 kB ljharb
npm/[email protected] None 0 26.3 kB ljharb
npm/[email protected] None +3 4.89 MB dschnurr, dschnurr-openai, jeevnayak, ...2 more
npm/[email protected] None 0 7.83 MB prettier-bot
npm/[email protected] None 0 24.1 kB lukeed
npm/[email protected] None +1 71.3 kB mafintosh
npm/[email protected] None 0 490 kB gregthegreek, jdevcs, luu-alex, ...1 more
npm/[email protected] None 0 419 kB luu-alex
npm/[email protected] None +1 908 kB gregthegreek, jdevcs, luu-alex, ...1 more
npm/[email protected] None 0 1.37 MB gregthegreek, jdevcs, luu-alex, ...1 more
npm/[email protected] None 0 454 kB luu-alex
npm/[email protected] None +1 1.46 MB luu-alex
npm/[email protected] None 0 118 kB luu-alex
npm/[email protected] None 0 550 kB luu-alex
npm/[email protected] None 0 3.46 MB gregthegreek, jdevcs, luu-alex, ...1 more
npm/[email protected] None +1 42.3 kB ljharb

🚮 Removed packages: npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@expo/[email protected], npm/@sentry/[email protected], npm/@tanstack/[email protected], npm/@tanstack/[email protected], npm/@tanstack/[email protected], npm/@tanstack/[email protected], npm/@tanstack/[email protected], npm/@types/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected]

View full report↗︎

Copy link

github-actions bot commented Dec 3, 2024

Jest Report

Summary

Lines Statements Branches Functions
Coverage: 92%
92.99% (1752/1884) 85.41% (527/617) 95.87% (302/315)

Tests

Tests Skipped Failures Errors Time
872 0 💤 0 ❌ 0 🔥 12m 33s ⏱️
Coverage (92%)
File% Stmts% Branch% Funcs% LinesUncovered Line #s
All files92.9985.4195.8792.74 
AccountUtils100100100100 
   AccountUtils.ts100100100100 
ActivityUtils100100100100 
   ActivityUtils.ts100100100100 
AddressUtils100100100100 
   AddressUtils.ts100100100100 
AlertUtils10010080100 
   Alert.ts10010080100 
ArrayUtils100100100100 
   ArrayUtils.ts100100100100 
BalanceUtils97.878010097.61 
   BalanceUtils.ts97.878010097.6178
BigNumberUtils10097.22100100 
   BigNumberUtils.ts10097.22100100184
BiometricsUtils95.389591.6696.29 
   BiometricErrors.ts88.8891.668091.354–55
   Biometrics.ts100100100100 
BloomUtils100100100100 
   BloomUtils.ts100100100100 
CacheKeyUtils100100100100 
   CacheKeyUtils.ts100100100100 
ColorUtils100100100100 
   ColorUtils.ts100100100100 
CryptoUtils96.5978.5710097.56 
   CryptoUtils.ts96.5978.5710097.5650, 68
CryptoUtils/Helpers76.3458.6288.8876.34 
   fastKeystoreDecrypt.ts76.3458.6288.8876.3433, 53, 69, 75, 80, 104, 110, 126, 138–162
CryptoUtils_Legacy100100100100 
   CryptoUtils_Legacy.ts100100100100 
CryptoUtils_Legacy/Helpers76.3458.6288.8876.34 
   fastKeystoreDecrypt.ts76.3458.6288.8876.3433, 53, 69, 75, 80, 104, 110, 126, 138–162
DAppUtils63.1552.837561.81 
   DAppUtils.ts63.1552.837561.8158, 65–116
DateUtils100100100100 
   DateUtils.ts100100100100 
DeviceUtils100100100100 
   DeviceUtils.ts100100100100 
ErrorMessageUtils100100100100 
   ErrorMessageUtils.ts100100100100 
FormUtils100100100100 
   FormUtils.ts100100100100 
FormattingUtils96.8791.66100100 
   FormattingUtils.ts96.8791.6610010026
GasUtils93.0573.810094.11 
   GasUtils.ts93.0573.810094.1152, 202–206
HexUtils94.2875100100 
   HexUtils.ts94.287510010063–65
IPFSUtils100100100100 
   IPFSUtils.ts100100100100 
LedgerUtils75.2491.6683.3373.95 
   LedgerUtils.ts75.2491.6683.3373.9583–87, 125–150, 179–184, 229–237, 294, 313–314
LocaleUtils10050100100 
   LocaleUtils.ts100501001006
LockScreenUtils100100100100 
   LockScreenUtils.ts100100100100 
Logger958010095 
   Logger.ts95801009538
MathUtils100100100100 
   MathUtils.ts100100100100 
MediaUtils100100100100 
   MediaUtils.ts100100100100 
MergeUtils100100100100 
   MergeUtils.ts100100100100 
PasswordUtils76.19505075 
   PasswordUtils.ts76.1950507563–64, 68, 72–73
PicassoUtils100100100100 
   PicassoUtils.ts100100100100 
PlatformUtils100100100100 
   PlatformUtils.ts100100100100 
ReanimatedUtils91.8973.3310093.93 
   Reanimated.ts91.8973.3310093.9351, 63
SemanticVersionUtils100100100100 
   SemanticVersionUtils.ts100100100100 
SignMessageUtils100100100100 
   SignMessageUtils.ts100100100100 
StringUtils100100100100 
   StringUtils.ts100100100100 
TokenUtils100100100100 
   TokenUtils.ts100100100100 
TransactionUtils97.2692.197.2997.64 
   TransactionUtils.ts97.2692.197.2997.64706–712, 802–806
TransfersUtils10080100100 
   TransfersUtils.ts10080100100100
URIUtils100100100100 
   URIUtils.ts100100100100 
WalletConnectUtils89.990.988.2390.29 
   WalletConnectUtils.tsx89.990.988.2390.2924–47

@Doublemme Doublemme merged commit f24af48 into main Dec 4, 2024
5 of 7 checks passed
@Doublemme Doublemme deleted the fix-toast-notification-address branch December 4, 2024 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Toast notification addresses not displaying
2 participants