Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance ux cloud backup #2439

Merged

Conversation

paolampilla
Copy link
Contributor

Related Issue

Closes #2436

Description of Changes

Updated designs for backup flow integrated and conflicts resolved.

  • add separate states for cloud vs manual backup to keep track if wallet has been backed up manually or by cloud
  • add dark styles for Privacy & Security screen
  • add label to show wallet has been backed up manually
  • change copy of importing from cloud screen

Reviewer(s)

@grenos @Doublemme @mfrezzati

UI/UX Changes

Backed up cloud & manually

Simulator Screenshot - iPhone 15 Pro - 2024-11-26 at 09 35 31

Backed up manually only

Simulator Screenshot - iPhone 15 Pro - 2024-11-26 at 08 45 22

Import wallet from cloud password screen

Simulator Screenshot - iPhone 15 Pro - 2024-11-26 at 08 44 03

Simulator Screenshot - iPhone 15 Pro - 2024-11-26 at 08 44 57

Checklist

  • Code adheres to project guidelines and conventions.
  • Unit tests, if applicable, are updated and passing.
  • Documentation, if applicable, has been updated.
  • UI/UX changes include visuals (video or screenshots).

Thank you for contributing! 🎉

Copy link

github-actions bot commented Nov 26, 2024

Jest Report

Summary

Lines Statements Branches Functions
Coverage: 92%
92.99% (1752/1884) 85.41% (527/617) 95.87% (302/315)

Tests

Tests Skipped Failures Errors Time
872 0 💤 0 ❌ 0 🔥 12m 35s ⏱️
Coverage (92%)
File% Stmts% Branch% Funcs% LinesUncovered Line #s
All files92.9985.4195.8792.74 
AccountUtils100100100100 
   AccountUtils.ts100100100100 
ActivityUtils100100100100 
   ActivityUtils.ts100100100100 
AddressUtils100100100100 
   AddressUtils.ts100100100100 
AlertUtils10010080100 
   Alert.ts10010080100 
ArrayUtils100100100100 
   ArrayUtils.ts100100100100 
BalanceUtils97.878010097.61 
   BalanceUtils.ts97.878010097.6178
BigNumberUtils10097.22100100 
   BigNumberUtils.ts10097.22100100184
BiometricsUtils95.389591.6696.29 
   BiometricErrors.ts88.8891.668091.354–55
   Biometrics.ts100100100100 
BloomUtils100100100100 
   BloomUtils.ts100100100100 
CacheKeyUtils100100100100 
   CacheKeyUtils.ts100100100100 
ColorUtils100100100100 
   ColorUtils.ts100100100100 
CryptoUtils96.5978.5710097.56 
   CryptoUtils.ts96.5978.5710097.5650, 68
CryptoUtils/Helpers76.3458.6288.8876.34 
   fastKeystoreDecrypt.ts76.3458.6288.8876.3433, 53, 69, 75, 80, 104, 110, 126, 138–162
CryptoUtils_Legacy100100100100 
   CryptoUtils_Legacy.ts100100100100 
CryptoUtils_Legacy/Helpers76.3458.6288.8876.34 
   fastKeystoreDecrypt.ts76.3458.6288.8876.3433, 53, 69, 75, 80, 104, 110, 126, 138–162
DAppUtils63.1552.837561.81 
   DAppUtils.ts63.1552.837561.8158, 65–116
DateUtils100100100100 
   DateUtils.ts100100100100 
DeviceUtils100100100100 
   DeviceUtils.ts100100100100 
ErrorMessageUtils100100100100 
   ErrorMessageUtils.ts100100100100 
FormUtils100100100100 
   FormUtils.ts100100100100 
FormattingUtils96.8791.66100100 
   FormattingUtils.ts96.8791.6610010026
GasUtils93.0573.810094.11 
   GasUtils.ts93.0573.810094.1152, 202–206
HexUtils94.2875100100 
   HexUtils.ts94.287510010063–65
IPFSUtils100100100100 
   IPFSUtils.ts100100100100 
LedgerUtils75.2491.6683.3373.95 
   LedgerUtils.ts75.2491.6683.3373.9583–87, 125–150, 179–184, 229–237, 294, 313–314
LocaleUtils10050100100 
   LocaleUtils.ts100501001006
LockScreenUtils100100100100 
   LockScreenUtils.ts100100100100 
Logger958010095 
   Logger.ts95801009538
MathUtils100100100100 
   MathUtils.ts100100100100 
MediaUtils100100100100 
   MediaUtils.ts100100100100 
MergeUtils100100100100 
   MergeUtils.ts100100100100 
PasswordUtils76.19505075 
   PasswordUtils.ts76.1950507563–64, 68, 72–73
PicassoUtils100100100100 
   PicassoUtils.ts100100100100 
PlatformUtils100100100100 
   PlatformUtils.ts100100100100 
ReanimatedUtils91.8973.3310093.93 
   Reanimated.ts91.8973.3310093.9351, 63
SemanticVersionUtils100100100100 
   SemanticVersionUtils.ts100100100100 
SignMessageUtils100100100100 
   SignMessageUtils.ts100100100100 
StringUtils100100100100 
   StringUtils.ts100100100100 
TokenUtils100100100100 
   TokenUtils.ts100100100100 
TransactionUtils97.2692.197.2997.64 
   TransactionUtils.ts97.2692.197.2997.64706–712, 802–806
TransfersUtils10080100100 
   TransfersUtils.ts10080100100100
URIUtils100100100100 
   URIUtils.ts100100100100 
WalletConnectUtils89.990.988.2390.29 
   WalletConnectUtils.tsx89.990.988.2390.2924–47

Copy link

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/[email protected] None 0 152 kB kilianvalkhof
npm/[email protected] None +3 4.89 MB dschnurr, dschnurr-openai, jeevnayak, ...2 more
npm/[email protected] None 0 7.85 MB azz, duailibe, fisker, ...8 more
npm/[email protected] network +5 16.7 MB jmoxey

🚮 Removed packages: npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected]

View full report↗︎

@marcofrezzati-vechain marcofrezzati-vechain merged commit a0ce2ac into 2418-gdrive---fix-permissions Nov 26, 2024
5 of 7 checks passed
@marcofrezzati-vechain marcofrezzati-vechain deleted the enhance-ux-cloud-backup branch November 26, 2024 12:29
Doublemme added a commit that referenced this pull request Nov 30, 2024
* feat: refactor android backup logic and improve navigation flows

* feat: handle saveWallet error result

* feat: complete google drive refactor

* fix: check if wallet exist and handle error during backup check

* fix: improving permission handling

* feat: add mixapanels event

* feat: add feature flag

* fix: tests

* Delete datadog-ci.json

* fix: handle no folder found error

* Enhance ux cloud backup (#2439)

* refactor: wallet backup status rows

* chore: add strings to import cloud page

* refactor: enhance cloud backup ux

* fix: fix sonarcloud issues

* fix: fix sonarcloud duplication

---------

Co-authored-by: mfrezzati <[email protected]>

* fix: add testId to wallet row for e2e text

* Delete cloud backup flow (#2443)

* chore: add delete cloud modals ans strings

* refactor: delete cloud backup

* fix: fix sonar warnings

* fix: fix sonar warnings

* fix: throw errors on cloudkit

* fix: cloud errors

* fix: backup modal show condition

* fix: remove thrown

* fix: added return statement on saving cloud wallet

* fix: add return

* fix: removed unused code

* fix: removed unused code

---------

Co-authored-by: Michael Martin <[email protected]>
Co-authored-by: paolampilla <[email protected]>
Co-authored-by: paolampilla <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enahncements to back up flow - cloud button state& label for manual.
2 participants