-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implemented coingecko proxy #2437
Conversation
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
🚮 Removed packages: npm/[email protected], npm/[email protected], npm/[email protected] |
Jest ReportSummary
Tests
Coverage (92%)
|
@Doublemme should we render a skeleton in the right part of the card ? |
Yeah @akanoce nice suggestion. We can render a skeleton so the user do not see 0 values while other parts of the card are still loading |
@akanoce Added skeleton on USD and 24h change rate Simulator.Screen.Recording.-.iPhone.15.Pro.-.2024-11-27.at.10.01.22.mp4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a small comment on this. Overall, great work!
Related Issue
Closes #2428
Closes #2468
Description of Changes
Re implemented the Coingecko proxy for fetch tokens balances and charts, added B3TR chart card
Added fiat balances of non Vechain tokens provided by VechainStats and fetched from the proxy
Reviewer(s)
@grenos @mfrezzati
UI/UX Changes
Android_proxy_balances.webm
Simulator.Screen.Recording.-.iPhone.15.Pro.Max.-.2024-11-25.at.16.16.10.mp4
Simulator.Screen.Recording.-.iPhone.15.Pro.Max.-.2024-12-04.at.18.43.14.mp4
Simulator.Screen.Recording.-.iPhone.15.Pro.Max.-.2024-12-04.at.18.41.17.mp4
Checklist
Thank you for contributing! 🎉