Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove swap button for observed accounts #2219

Merged
merged 2 commits into from
Aug 28, 2024

Conversation

marcofrezzati-vechain
Copy link
Contributor

No description provided.

@marcofrezzati-vechain marcofrezzati-vechain linked an issue Aug 27, 2024 that may be closed by this pull request
Copy link

github-actions bot commented Aug 27, 2024

Jest Report

Summary

Lines Statements Branches Functions
Coverage: 95%
95.08% (1624/1708) 90.64% (494/545) 97.3% (289/297)

Tests

Tests Skipped Failures Errors Time
854 0 💤 0 ❌ 0 🔥 10m 3s ⏱️
Coverage (95%)
File% Stmts% Branch% Funcs% LinesUncovered Line #s
All files95.0890.6497.395.15 
AccountUtils100100100100 
   AccountUtils.ts100100100100 
ActivityUtils100100100100 
   ActivityUtils.ts100100100100 
AddressUtils100100100100 
   AddressUtils.ts100100100100 
AlertUtils10010080100 
   Alert.ts10010080100 
ArrayUtils100100100100 
   ArrayUtils.ts100100100100 
BalanceUtils97.8287.510097.56 
   BalanceUtils.ts97.8287.510097.5678
BigNumberUtils98.6896.77100100 
   BigNumberUtils.ts98.6896.77100100179
BiometricsUtils95.389591.6696.29 
   BiometricErrors.ts88.8891.668091.354–55
   Biometrics.ts100100100100 
BloomUtils100100100100 
   BloomUtils.ts100100100100 
CacheKeyUtils100100100100 
   CacheKeyUtils.ts100100100100 
ColorUtils100100100100 
   ColorUtils.ts100100100100 
CryptoUtils98.7191.66100100 
   CryptoUtils.ts98.7191.66100100119
CryptoUtils/Helpers76.3458.6288.8876.34 
   fastKeystoreDecrypt.ts76.3458.6288.8876.3433, 53, 69, 75, 80, 104, 110, 126, 138–162
DAppUtils97.0596.5510096.96 
   DAppUtils.ts97.0596.5510096.9655
DateUtils100100100100 
   DateUtils.ts100100100100 
DeviceUtils100100100100 
   DeviceUtils.ts100100100100 
ErrorMessageUtils100100100100 
   ErrorMessageUtils.ts100100100100 
FormUtils100100100100 
   FormUtils.ts100100100100 
FormattingUtils96.8791.66100100 
   FormattingUtils.ts96.8791.6610010026
GasUtils93.0573.810094.11 
   GasUtils.ts93.0573.810094.1152, 202–206
HexUtils94.2875100100 
   HexUtils.ts94.287510010063–65
IPFSUtils100100100100 
   IPFSUtils.ts100100100100 
LanguageUtils10050100100 
   LanguageUtils.ts1005010010017
LedgerUtils75.2491.6683.3373.95 
   LedgerUtils.ts75.2491.6683.3373.9583–87, 125–150, 179–184, 229–237, 294, 313–314
LocaleUtils10050100100 
   LocaleUtils.ts100501001006
LockScreenUtils100100100100 
   LockScreenUtils.ts100100100100 
Logger958010095 
   Logger.ts95801009538
MathUtils100100100100 
   MathUtils.ts100100100100 
MediaUtils100100100100 
   MediaUtils.ts100100100100 
MergeUtils100100100100 
   MergeUtils.ts100100100100 
PasswordUtils100100100100 
   PasswordUtils.ts100100100100 
PicassoUtils100100100100 
   PicassoUtils.ts100100100100 
PlatformUtils100100100100 
   PlatformUtils.ts100100100100 
ReanimatedUtils91.8973.3310093.93 
   Reanimated.ts91.8973.3310093.9351, 63
SemanticVersionUtils100100100100 
   SemanticVersionUtils.ts100100100100 
SignMessageUtils100100100100 
   SignMessageUtils.ts100100100100 
StringUtils100100100100 
   StringUtils.ts100100100100 
TokenUtils100100100100 
   TokenUtils.ts100100100100 
TransactionUtils97.2692.197.2997.64 
   TransactionUtils.ts97.2692.197.2997.64706–712, 802–806
TransfersUtils10080100100 
   TransfersUtils.ts10080100100100
URIUtils100100100100 
   URIUtils.ts100100100100 
WalletConnectUtils89.4290.2487.589.79 
   WalletConnectUtils.tsx89.4290.2487.589.7924–47

Copy link
Collaborator

@Doublemme Doublemme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are UX/UI changes so please remember to attach a screenshot or screen record of the changes

@marcofrezzati-vechain
Copy link
Contributor Author

Simulator Screenshot - iPhone 15 Pro - 2024-08-28 at 14 49 45

@Doublemme Doublemme merged commit 1f14b8e into main Aug 28, 2024
7 checks passed
@Doublemme Doublemme deleted the 2218-remove-swap-button-when-a-wallet-is-observed branch August 28, 2024 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove Swap button when a wallet is observed
2 participants