Dp container copy 2 #20
Closed
+162
−95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Make copy assignment operator protected to avoid slicing
Make copy assignment operator protected Update unit tests to match
Test container assignment
|
Closing as superseded by nasa#2711. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a revised version of #19. I've submitted a separate PR for comparison. This version adds derived classes of
ExternalSerializeBufferwith data and member copy semantics. I think this version may be better because it relies more on the C++ compiler and requires less manual code and generated code. In particular, the issue that we saw is fixed with no updates to FPP code gen. If we go with the solution in #19, then any object that includes an ExternalSerializeBuffer as a member will need a manual and/or code-generated copy assignment operator. @timcanham @LeStarch see what you think.