Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dp container copy #19

Closed
wants to merge 5 commits into from

Conversation

bocchino
Copy link

Fixes to DP container copying, as discussed. Note that a small change to FPP code gen is required. For now I have hand-coded the workarounds and marked them with TODOs.

@bocchino
Copy link
Author

@LeStarch FYI.

@timcanham
Copy link
Owner

So the DpContainer::copyMembersFrom() is a temporary measure until there is new FPP?

@bocchino
Copy link
Author

@bocchino
Copy link
Author

I'm proposing to keep the copyMembersFrom syntax. As discussed, it's more explicit about what's going on than an overloaded operator=.

@timcanham
Copy link
Owner

I thought that was just for the underlying ExternalSerializeBuffer. I think the container should have an = operator.

@bocchino
Copy link
Author

OK, when I update the FPP code gen I can add a protected operator= in the base class and add a public operator= in the derived class that calls it. I don't want to add a public operator= in the base class -- that's contrary to C++ coding rules.

@bocchino bocchino mentioned this pull request Apr 28, 2024
@bocchino
Copy link
Author

Closing in favor of #20.

@bocchino bocchino closed this Apr 29, 2024
@bocchino bocchino deleted the dp-container-copy branch April 29, 2024 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants