Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support InvalidTypeApplication on #update_env #1507

Merged
merged 2 commits into from
Mar 7, 2025

Conversation

ksss
Copy link
Contributor

@ksss ksss commented Feb 25, 2025

ref: ruby/rbs#2289

When InvalidTypeApplicationError occurs in the RBS validator, there is a possibility that Steep will raise an Unexpected error if the type argument is RBS::Types::ClassInstance, RBS::Types::Interface, or RBS::Types::Alias.

This PR fixes the issue so that problems are reported correctly.

@soutaro soutaro added this to the Steep 1.10 milestone Mar 6, 2025
@ksss ksss force-pushed the ancestors-invalid-type-application branch from de9b047 to e8c3420 Compare March 6, 2025 13:12
@ksss ksss marked this pull request as ready for review March 6, 2025 13:18
Copy link
Owner

@soutaro soutaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 👍

@soutaro soutaro merged commit 3a9786b into soutaro:master Mar 7, 2025
17 checks passed
@ksss ksss deleted the ancestors-invalid-type-application branch March 7, 2025 06:25
@soutaro soutaro added the Released The PR is already included in a published release label Mar 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Released The PR is already included in a published release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants