Validate superclass and module-self-type #2289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ksss
added a commit
to ksss/steep
that referenced
this pull request
Feb 25, 2025
ksss
added a commit
to ksss/steep
that referenced
this pull request
Mar 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I propose to validate for type application on the superclass and modules-self-type.
This change will allow users to quickly recognize this type specification error.
Note
This change will cause Unexpected error in steep and needs to be corrected.
This is because
RBS::InvalidTypeApplicationErroris not expected to occur in certain cases.https://github.com/soutaro/steep/blob/5705673a6ef631771cda36a77b4dc7c0294a3941/lib/steep/services/signature_service.rb#L297-L298