The View/Remove Edit Reasons box needs change. #377
Comments
|
Thanks, revamping that modal's UI is on my todo list, to make it look like SE's modals. See the custom magic links feature's modal for an idea of how it will soon look!
Thanks for the other suggestions on functionality, I'll see what I can do about them :)
|
|
@Ethan-JK I've done all the design change in dev 2.3.27. I didn't get round to the edit/reorder functionality (it's slightly more involved than design changes!) so will try getting that done at a later date. Looking at the SOX code, a lot of features' code can be improved, so I may rewrite this entirely instead! Please let me know if the design changes are what you were thinking of! |
|
@shu8 Wow! Thank looks really good! One thing: The delete button is a little too bold. Could you make the button less bold or the text next to it bolder? |
|
Sure, I'll get that done soon :) |
|
@Ethan-JK How's the delete button now in dev 2.3.29? |
|
@shu8 Nice! I was kind of thinking of something plain like this:
With the delete button being the same as the discard button for a question/answer. |
shu8
added a commit
that referenced
this issue
Feb 3, 2019
|
@Ethan-JK Thanks for the mockup! How's it now in dev 2.3.30? I've also added the edit option :)
|
shu8
added a commit
that referenced
this issue
Feb 3, 2019
* new dev * #305 * #307 * #310 * #310 * Better fix for #310 The old fix placed the SOX button to the right of the username, but the username only shows up in the top bar if you're logged in. This meant the SOX button would be absent if you were logged out. This new code should fix that. * #310 * #309, #313 * #311, #312 * #256 * #319, #317, #316 * #256 * #318 * #294 deprecate enhanced editor * #308, other small fixes * #320 * minor fixes (#324) change scroll top top feature JSON info * fixes #329 (#330) also reduces jQuery dependency * v2.1.4 DEV before push to master also adds #326 * v2.2.0 * inital DEV push * update readme to state GM not supported; #306 * reduce dependency on `hotkeys`+minor details (#333) * #334 fixed * #334 * #334 * #338 * #335, #338 * Micro optimizations (#336) * update source link * micro optimizations - converted jQuery .not to CSS selector for faster perf (https://stackoverflow.com/questions/8845811/performance-differences-between-using-not-and-not-selectors) - introduced a separate function to eliminate thrice-repeated (!) code, to keep it DRY * fixes some issues (#339) described in #338 (comment) * fixes #338 * fixes #338 (#340) 1. used addEventListener instead of onload 2. descriptive names (`reader`) 3. optimized extraction of the image URL from the `data` 4. made all declarations `var` and moved them into one place for consistency 5. shortened the POST url to simply `'/upload/image?https=true',` ;P * #322 implemented * Sticky property * Update sox.user.js * Updating button colors The main SE buttons use a lighter color than the SOX buttons * Update sox.css * Minor fixes Patched a problem with vote buttons, and fixed the color of the notify on edit button * Update sox.user.js * minor changes/fixes * #341 temporary fix * Updated mod diamond icon Updated to the icon, to match the one used by the new topbar * Updated diamond icon * Updated mod diamond * improvements in colorAnswerer (#344) * improvements in colorAnswerer 1. constant variables+cache answeredID 2. reduce jQuery dependency+shorter a[href] selector via user ID 3. change coloration * optimization: use filters throughout (#345) reduces bandwidth consumption * fixes a few features; adds CSS Fixes moveBounty, dragBounty, copyCommentsLink. Adds class for colorAnswerer. Updates jQuery * fixes quickAuthorInfo fontawesome icon * fix a few of #308 * Major improvements in code extensibility, reduced API usage, eliminate redundancy, etc. (#348) * fixes various bugs mentioned in #348 * fixes standOutDupeCloseMigrated for search pages * remove unwanted console logs * #347, various minor tweaks * fixes small bug in parseCrossSiteLinks e.g. on this comment: https://meta.stackoverflow.com/questions/370902/i-need-a-lot-of-help-to-write-a-query-for-the-stack-exchange-data-explorer-sh?cb=1#comment608548_370902 * Fixed Meta SE's chat link Added a / to the end of Meta SE's if statement to fix it. Also replaced "discuss" with "meta" for Area 51 (to match the new URL for Area 51 Discussions), shortened a bit of code, and added some comments * Fixed Meta SE links * Changed topbar z-index Changed the fixed topbar's z-index to match the one on SO, in order to prevent elements like the usercard (z-index: 1000) from covering it * Made it clearer what the checkbox does * Many fixes to dialog buttons Fixes many of the bugs from #308 * Many fixes to dialog buttons Fixes many of the bugs from #308 * Many fixes to dialog buttons Fixes many of the bugs from #308 * Many fixes to dialog buttons Fixes many of the bugs from #308 * Fixed Area 51 Discussions bug * #348 minor tweak * fix (#350) ...for answerer ID 13 also matching commenter ids beginning with 13 (1345, 13555, etc.) * #352, #353 remove yahoo YQL use * #352 * PR/351 (#355) * update getQuestionTags * provide immediate response to user * minor changes * #325: remove rangyInputs dependency (#354) * bump version number * remove downvotedPostsEditAlert; remove rangyinputs `require`; implement mini changelog in dialog * install stale and no-response bots * #356 added, minor bug fix * start #349, start to move to es6 * onlyShowCommentActionsOnHover bug fix * #357 * deprecate fixedTopbar feature for #349 * add showTagWikiLinkOnTagPopup feature * #359 fixed * #358 fixed * fixes #360 * fixes for #361 * #361 changes * v2.3.0 final * 2.3.0 DEV * fix for #363 * implemented 'feature packs' in settings dialog * debugging for #363, fixes #364 * #363 debugging * fix for #363 * #361 implemented (access token no longer mandatory); minor code cleanup * #365 * fix #368 * Add #315 * fix #366 * start to use linting * fix #372 * add #370 * clean up code * implement #374 * fix #373 * add #370; deprecate pasteImagesDirectly * #374 replace 'help' instead of prepend new link * change indentation to 2 spaces * lint * implement #296 * implements #376 (linkify meta diamond dialog title) * fix #375 (topAnswers post score not being found) * improve customMagicLinks feature -- add button to help menu on all pages * fix sticky vote buttons feature * keep new meta posts under diamond even after clicking (#378) * editComment improve design, add more defaults (#377) * fix better css feature * editComment: make dialog delete button smaller * improve editComment for #377; allow editing; new setting storage format * add delay to comment features for links to deleted comments #379 * bump to v2.4.0 * Remove accidental letter introduced into file * Bump installation link version numbers * Lint
|
@shu8 Cool! That looks and works great! One thing - are there any plans to move around the order of the reasons? Other than that, this looks awesome! |
|
@Ethan-JK glad you like it! To be honest, I'm not sure how useful people would find re-ordering the reasons -- could I ask whether your main use case would be for the dialog where it lists all your reasons or for the actual checkboxes when editing? |
|
@shu8 I don't care about the order in the dialog, the main use would be for the actual checkboxes while editing. My thought for this is to be able to move the reasons around in the dialog and the changes would be reflected in the editing screen. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
A few things:
No margin between the delete button and the text.
Just see for yourself:
Can you add a
margin-right/-left?No edit button.
Please add a button to the left of the delete one to edit it.
No way to reorder.
Can not change the order in which options appear without deleting all of them and reading in a different order. Can you make a drag & drop interface or up and down buttons?
Needes two more default reasons: title & retag.
Make the delete button red, not blue.
If the edit button is added, that one should still be blue.
The window opens by default position blocked by the top bar.
See the image.
The text was updated successfully, but these errors were encountered: