Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: nicheVI release #3172
base: main
Are you sure you want to change the base?
feat: nicheVI release #3172
Changes from all commits
ce557a8
2c27373
0e2808a
9bba0db
50b3ff7
d08ce84
7981061
25434f7
c268f4a
cbf2b35
24c89f3
e63ccdb
16691c9
f4c8da2
fead31c
b481e34
5070243
2a249e7
be4aef9
f2a0a40
6cf60f6
b82fec1
dd80ec4
c4c19e1
69f58c5
0d09cd5
6e4ea7e
b6c7f85
9247f5d
513d2e1
89c15d5
e903329
b2643dc
a076d4d
fb4bb0b
326a1a4
ccfa16f
143b591
b4966ec
83cff0b
80ab2a1
27d8a12
d0aa175
fdd6279
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At least first letter large for classes. Just call the class NICHEVI - will be more user friendly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Duplicate.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a convention that we start a class name with Capital letter
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
as soon as I finish running experiments, because you can't load models if you changed the class
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You need to release a reproducibility repo with the version of code that you used and use this for revision. See resolVI archive in my GitHub.