Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: nicheVI release #3172

Open
wants to merge 38 commits into
base: main
Choose a base branch
from
Open

feat: nicheVI release #3172

wants to merge 38 commits into from

Conversation

LevyNat
Copy link
Collaborator

@LevyNat LevyNat commented Feb 3, 2025

No description provided.

Copy link

codecov bot commented Feb 3, 2025

Codecov Report

Attention: Patch coverage is 75.81699% with 185 lines in your changes missing coverage. Please review.

Project coverage is 80.02%. Comparing base (904567d) to head (326a1a4).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...hevi/differential_expression/_marker_classifier.py 27.47% 66 Missing ⚠️
src/scvi/external/nichevi/_module.py 68.96% 54 Missing ⚠️
src/scvi/external/nichevi/_model.py 86.11% 30 Missing ⚠️
...ernal/nichevi/differential_expression/_de_utils.py 73.46% 13 Missing ⚠️
.../nichevi/differential_expression/_niche_de_core.py 90.72% 9 Missing ⚠️
src/scvi/external/nichevi/_log_likelihood.py 75.00% 8 Missing ⚠️
...hevi/differential_expression/_results_dataclass.py 84.21% 3 Missing ⚠️
src/scvi/external/nichevi/_components.py 96.42% 2 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (904567d) and HEAD (326a1a4). Click for more details.

HEAD has 10 uploads less than BASE
Flag BASE (904567d) HEAD (326a1a4)
12 2
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3172      +/-   ##
==========================================
- Coverage   86.69%   80.02%   -6.68%     
==========================================
  Files         193      204      +11     
  Lines       17115    17880     +765     
==========================================
- Hits        14838    14308     -530     
- Misses       2277     3572    +1295     
Files with missing lines Coverage Δ
src/scvi/external/__init__.py 100.00% <100.00%> (ø)
src/scvi/external/nichevi/__init__.py 100.00% <100.00%> (ø)
src/scvi/external/nichevi/_constants.py 100.00% <100.00%> (ø)
...ternal/nichevi/differential_expression/__init__.py 100.00% <100.00%> (ø)
src/scvi/external/nichevi/_components.py 96.42% <96.42%> (ø)
...hevi/differential_expression/_results_dataclass.py 84.21% <84.21%> (ø)
src/scvi/external/nichevi/_log_likelihood.py 75.00% <75.00%> (ø)
.../nichevi/differential_expression/_niche_de_core.py 90.72% <90.72%> (ø)
...ernal/nichevi/differential_expression/_de_utils.py 73.46% <73.46%> (ø)
src/scvi/external/nichevi/_model.py 86.11% <86.11%> (ø)
... and 2 more

... and 27 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ori-kron-wis ori-kron-wis changed the title code for nicheVI feat: nicheVI release Feb 3, 2025
@ori-kron-wis ori-kron-wis added the on-merge: backport to 1.2.x on-merge: backport to 1.2.x label Feb 12, 2025
@ori-kron-wis ori-kron-wis added on-merge: backport to 1.3.x on-merge: backport to 1.3.x and removed on-merge: backport to 1.2.x on-merge: backport to 1.2.x labels Feb 25, 2025
@ori-kron-wis
Copy link
Collaborator

please also add changelog record, links to tutorials and model descriptions (see other models that were merged recently like resolvi, sysvi)

@canergen canergen added the draft label Feb 27, 2025
@@ -4,6 +4,7 @@
from .gimvi import GIMVI
from .methylvi import METHYLANVI, METHYLVI
from .mrvi import MRVI
from .nichevi import nicheSCVI
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At least first letter large for classes. Just call the class NICHEVI - will be more user friendly.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Duplicate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
draft on-merge: backport to 1.3.x on-merge: backport to 1.3.x
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants