Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add accents #13

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

feat: add accents #13

wants to merge 3 commits into from

Conversation

mvllow
Copy link
Member

@mvllow mvllow commented Mar 14, 2025

This will show in the help menu but remain undocumented in the readme for now in case the api changes

Closes #12

@mvllow mvllow mentioned this pull request Mar 14, 2025
@OyuDays
Copy link

OyuDays commented Mar 14, 2025

I have tested and this seems to be very unfinished
here are the issues i encountered (ordered from smallest to biggest issue):

  1. the option is not in the help menu like you said it would be.
  2. it does not work on folders, i think the reason is something like that the folders for the accents are never made, but are still attempted to be accessed
  3. $accent only gives the accent name, not the actual color, is this intentional? am i missing something?

@mvllow
Copy link
Member Author

mvllow commented Mar 14, 2025

Doh, not sure why my brain thought we wanted to use the colour name instead of the value. Should be fixed now, as well as adding the flag. It's been quite a while since I've worked in this codebase 😅

I'll have to think about the folders ~

@OyuDays
Copy link

OyuDays commented Mar 14, 2025

i suppose it would be easier to just call the folders as unintended and just leave it at that
even in my case where i do use the folders, i could very easily switch away from it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feature - accents
2 participants