Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature - accents #12

Open
OyuDays opened this issue Mar 13, 2025 · 3 comments · May be fixed by #13
Open

feature - accents #12

OyuDays opened this issue Mar 13, 2025 · 3 comments · May be fixed by #13

Comments

@OyuDays
Copy link

OyuDays commented Mar 13, 2025

add a variable $accent
with this variable (perhaps activated by a flag), it would generate a variant of the theme with the $accent variable as every accent color

example:

template.json

$ npx @rose-pine/build -t templates/ -o output/ --accent

output/
> rose-pine-love.json
> rose-pine-gold.json
> rose-pine-rose.json
> rose-pine-pine.json
> rose-pine-foam.json
> rose-pine-iris.json
> rose-pine-dawn-love.json
> rose-pine-dawn-gold.json
> rose-pine-dawn-rose.json
> rose-pine-dawn-pine.json
> rose-pine-dawn-foam.json
> rose-pine-dawn-iris.json
> rose-pine-moon-love.json
> rose-pine-moon-gold.json
> rose-pine-moon-rose.json
> rose-pine-moon-pine.json
> rose-pine-moon-foam.json
> rose-pine-moon-iris.json
@mvllow
Copy link
Member

mvllow commented Mar 13, 2025

I like this idea—my only concern is contrast. We would want to map an appropriate colour to be used atop each accent. E.g. if accent is pine, we would want something like:

.button {
  color: $($text|$text|$base);
  background: $accent;
}

But ideally, the color in the above example could be something like $on_accent and automatically get the correct foreground, as I assume it may not always be the same per accent.

@OyuDays
Copy link
Author

OyuDays commented Mar 13, 2025

i am not too concerned about contrast, i feel most of the places where you would put the accent would just naturally have things that contrast nicely enough (usually $text color in the examples i can think of)
my main reason for wanting this feature is just to make a more complete set of my theme instead of having to settle for a single color as the accent :)

@mvllow mvllow linked a pull request Mar 14, 2025 that will close this issue
@mvllow
Copy link
Member

mvllow commented Mar 14, 2025

Feel free to test out #13 :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants