-
Notifications
You must be signed in to change notification settings - Fork 336
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Travis/pkgdown sometimes fails when building the vignette due to memory, but not with the same objects earlier in R CMD check #1230
Comments
lcolladotor
added a commit
to LieberInstitute/spatialLIBD
that referenced
this issue
Feb 28, 2020
lcolladotor
added a commit
to LieberInstitute/spatialLIBD
that referenced
this issue
Feb 28, 2020
The only thing I can think to suggest is to |
lcolladotor
added a commit
to LieberInstitute/spatialLIBD
that referenced
this issue
Apr 22, 2020
Former-commit-id: 7e0ce2c04bed8e8178266e7dd87de71d2bea9f96 [formerly aad74a6] Former-commit-id: 8f0c2c7c44849fed96b6d69160323517563e63f8
lcolladotor
added a commit
to LieberInstitute/spatialLIBD
that referenced
this issue
Apr 22, 2020
Former-commit-id: b447bbeada6e17da9a127c065b39aa54c3b4d754 [formerly 9d39947] Former-commit-id: 7ae7a00bb0bcd656aa37fbaa007e02d912907d2a
lcolladotor
added a commit
to lcolladotor/biocthis
that referenced
this issue
May 9, 2020
Created both an introductory and a developer's notes vignette, updated README and docs with examples, added a second biocViews term, fixed some small bugs/typos. Related links (as many as I could remember): * https://rstd.io/tidytools19 * https://twitter.com/CVWickham * https://twitter.com/hadleywickham * https://www.rstudio.com/products/rstudio/download * https://comunidadbioinfo.github.io/post/building-tidy-tools-cdsb-runconf-2019/#.XrbLMxNKiu4 * http://bioconductor.org/ * https://lcolladotor.github.io/pkgs/ * https://stat.ethz.ch/pipermail/bioc-devel/2020-March/016365.html * https://www.bioconductor.org/help/docker/ * https://stat.ethz.ch/pipermail/bioc-devel/2020-April/016532.html * https://github.com/features/actions * https://stat.ethz.ch/pipermail/bioc-devel/2020-April/016650.html * r-lib/actions#84 * r-lib/usethis#1108 * r-lib/styler#636 * Bioconductor/BiocCheck#57 * Bioconductor/bioconductor.org#54 * http://bioconductor.org/developers/how-to/coding-style/ * https://style.tidyverse.org/ * https://twitter.com/lorenzwalthert * https://twitter.com/mt_morgan * https://docs.travis-ci.com/user/languages/r/ * r-lib/pkgdown#1206 * r-lib/pkgdown#1230 * https://twitter.com/jimhester_ * https://www.jimhester.com/talk/2020-rsc-github-actions/ * https://github.com/Bioconductor/BBS * https://github.com/Bioconductor/packagebuilder * https://www.appveyor.com/ * r-hub/rhub#52 * r-hub/rhub#38 * https://www.tidyverse.org/blog/2020/04/usethis-1-6-0/ * https://github.com/r-lib/actions/tree/master/examples * https://yihui.org/en/2018/03/second-pull-request/ * https://github.com/r-lib/actions/blob/master/examples/check-standard.yaml * https://help.github.com/en/actions * https://ropenscilabs.github.io/actions_sandbox/ * https://twitter.com/seandavis12 * https://github.com/seandavi/BiocActions/blob/master/.github/workflows/main.yml * https://twitter.com/CSoneson * https://github.com/csoneson/dreval/blob/master/.github/workflows/R-CMD-check.yaml * https://bioc-community.herokuapp.com/ * https://github.com/leekgroup/derfinderPlot/blob/master/.github/workflows/check-bioc.yml * https://github.com/LieberInstitute/recount3/blob/master/.github/workflows/check-bioc.yml * https://github.com/hpages * r-lib/actions#68 * r-lib/actions#85 * https://twitter.com/opencpu * https://community.rstudio.com/u/const-ae * https://community.rstudio.com/t/compiler-support-fo-c-14-features-on-windows/57284/4 * r-lib/xml2#296 * r-lib/xml2#302 * https://github.com/r-lib/usethis/blob/master/.github/workflows/R-CMD-check.yaml * https://github.com/r-lib/usethis/commits/master/.github/workflows/R-CMD-check.yaml * https://stat.ethz.ch/pipermail/bioc-devel/2020-April/016703.html * https://stat.ethz.ch/pipermail/bioc-devel/2020-April/thread.html * r-lib/remotes#296 * r-lib/actions#86 * r-lib/covr#427 * https://github.com/r-lib/actions/blob/master/examples/pr-commands.yaml * https://www.digitalocean.com/community/tutorials/how-to-install-git-on-ubuntu-18-04 * r-lib/actions#50 * actions/checkout#238 * https://github.com/rocker-org/rocker-versioned2/blob/master/dockerfiles/Dockerfile_rstudio_4.0.0-ubuntu18.04 * https://twitter.com/niteshturaga * https://twitter.com/cboettig * rocker-org/rocker-versioned#208 * https://github.community/t5/GitHub-Actions/bd-p/actions * https://www.r-consortium.org/blog/2020/03/18/cdsb-diversity-and-outreach-hotspot-in-mexico * https://github.com/maxheld83 * r-lib/actions#87 * https://github.com/yutannihilation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hi,
I'm a bit puzzled with a particular repository that sometimes fails deploying from Travis to GitHub due to out of memory errors and sometimes doesn't . The memory error always happens when
pkgdown
is building the vignette. The closestpkgdown
issue I could find was #783 though that one was closed due to a lack of access to the code.This particular package uses about 2.5 GB of RAM in memory of R objects simply to get going, so yes, it's a beast. Something that really puzzles me is that the examples run fine (
R CMD check
) and the Travis build never fails at that point. My understanding is thatpkgdown::deploy_site_github()
is run on a new R process at the end, such that it should in theory have the exact same memory to use as the R process thatR CMD check
earlier. However if the two R processes are active at the same time, this could double the memory and bring it close to the 7.5 GB RAM limit of the Google Compute Engine used by Travis as detailed in their docs leading to the cases where sometimes it runs out of memory and sometimes it doesn't.I'd appreciate if you have any suggestions that I could try or if there's more information that I provide you.
Best,
Leo
Hm...
As I write this, I realize that a more likely case is that the R process running
pkgdown::deploy_site_github()
keeps all the same objects used in the examples around as when building the vignette. Currently my examples use code like this (includes roxygen format):but then in the vignette I use
sce <- fetch_data('sce')
. Hm... However, I actually don't use that big object in the vignette. I created a fake version that I use then (96.5 Mb) (details here).I will test a version where I use the
if (!exists())
syntax with the same object names through both the docs and the vignette.Error message
Ok, here's the actual error message copy-pasted from https://travis-ci.com/LieberInstitute/spatialLIBD/builds/150899142#L1106-L1167.
Recent build history
I inspected the recent build history to see if I could pick up any patterns. From the Travis docs I learnt that the worker information specifies which infrastructure was used. I see several GCE-production-1, 2 and 3, which from the docs, are the instances with 7.5 GB of RAM. I don't really see any clues, though maybe you do pick up some.
Build 31: worked!
Build 32: worked!
Build 33: failed! (other error)
note that this one failed due to an actual error with R CMD check that I introduced
Build 34: worked!
Build 35: worked!
Build 36: failed! (other error)
note that this one failed due to an actual error with R CMD check that I introduced
Build 37: failed! (
pkgdown
error)note that this one failed due to an actual error with R CMD check that I introduced
Build 38: failed! (
pkgdown
error)note that this one failed due to an actual error with R CMD check that I introduced
Build 39: failed! (
pkgdown
error)note that this one failed due to an actual error with R CMD check that I introduced
Repository in question
.travis.yml
code that callspkgdown
: https://github.com/LieberInstitute/spatialLIBD/blob/2030888d0b0ef98fc4409d749af1b5f62dec8ae0/.travis.yml#L10-L13RcppAnnoy
version 0.0.14 instead of the latest (from today) version 0.0.15 (due to this issue) which you can install withremotes::install_version('RcppAnnoy', version = '0.0.14')
as done in the.travis.yml
code here.Unlike when I wrote https://twitter.com/fellgernon/status/1231483308120444929?s=20, I can now actually post an issue since we made the GitHub repository public so we could submit it to Bioconductor.
Locally
Unlike the previous issue #783, I do not encounter this problem locally on my macOS (16 GB of RAM). I even made a script that I would run manually to update my website using the internals of
pkgdown
. While monitoring the memory usage with the macOS Activity Monitor, I saw no jumps during this whole process, also unlike #783.Local R session information
The text was updated successfully, but these errors were encountered: