covr::codecov() fails on a package without functions

[lcolladotor]

Hi,

I'm just starting a new package and setting things up (first time using GitHub actions) and ran into an error which I assume is simply because the package currently has no functions yet. This is related #57.

Anyway, it's a simple error but the error message could be confusing. Hence why I'm reporting it.

• Package at this moment: https://github.com/LieberInstitute/recount3/tree/06c06749bdd9a5b50b49d8826914307adb5617aa
• GitHub action logs: https://github.com/LieberInstitute/recount3/runs/586237798?check_suite_focus=true

Best,
Leo

Error reproduced locally

> covr::codecov()
Error in aggregate.data.frame(mf[1L], mf[-1L], FUN = FUN, ...) : 
  no rows to aggregate
> traceback()
11: stop("no rows to aggregate")
10: aggregate.data.frame(mf[1L], mf[-1L], FUN = FUN, ...)
9: aggregate.formula(value ~ ., x, sum)
8: aggregate(value ~ ., x, sum)
7: merge_values(df)
6: as.data.frame.coverage(coverage)
5: as.data.frame(coverage)
4: per_line(x)
3: lapply(per_line(x), function(xx) {
       xx$coverage <- c(NA, xx$coverage)
       xx
   })
2: to_codecov(coverage)
1: covr::codecov()

Local R session information

> library('sessioninfo')
> options(width = 120)
> session_info()
─ Session info ───────────────────────────────────────────────────────────────────────────────────────────────────────
 setting  value                       
 version  R version 3.6.3 (2020-02-29)
 os       macOS Catalina 10.15.4      
 system   x86_64, darwin15.6.0        
 ui       RStudio                     
 language (EN)                        
 collate  en_US.UTF-8                 
 ctype    en_US.UTF-8                 
 tz       America/New_York            
 date     2020-04-14                  

─ Packages ───────────────────────────────────────────────────────────────────────────────────────────────────────────
 package     * version date       lib source                            
 assertthat    0.2.1   2019-03-21 [1] CRAN (R 3.6.0)                    
 backports     1.1.6   2020-04-05 [1] CRAN (R 3.6.3)                    
 callr         3.4.3   2020-03-28 [1] CRAN (R 3.6.2)                    
 cli           2.0.2   2020-02-28 [1] CRAN (R 3.6.0)                    
 colorout    * 1.2-1   2019-05-07 [1] Github (jalvesaq/colorout@7ea9440)
 covr          3.5.0   2020-03-06 [1] CRAN (R 3.6.0)                    
 crayon        1.3.4   2017-09-16 [1] CRAN (R 3.6.0)                    
 desc          1.2.0   2018-05-01 [1] CRAN (R 3.6.0)                    
 devtools    * 2.3.0   2020-04-10 [1] CRAN (R 3.6.3)                    
 digest        0.6.25  2020-02-23 [1] CRAN (R 3.6.0)                    
 ellipsis      0.3.0   2019-09-20 [1] CRAN (R 3.6.0)                    
 fansi         0.4.1   2020-01-08 [1] CRAN (R 3.6.0)                    
 fs            1.4.1   2020-04-04 [1] CRAN (R 3.6.3)                    
 glue          1.4.0   2020-04-03 [1] CRAN (R 3.6.3)                    
 lazyeval      0.2.2   2019-03-15 [1] CRAN (R 3.6.0)                    
 magrittr      1.5     2014-11-22 [1] CRAN (R 3.6.0)                    
 memoise       1.1.0   2017-04-21 [1] CRAN (R 3.6.0)                    
 packrat       0.5.0   2018-11-14 [1] CRAN (R 3.6.0)                    
 pkgbuild      1.0.6   2019-10-09 [1] CRAN (R 3.6.0)                    
 pkgload       1.0.2   2018-10-29 [1] CRAN (R 3.6.0)                    
 prettyunits   1.1.1   2020-01-24 [1] CRAN (R 3.6.2)                    
 processx      3.4.2   2020-02-09 [1] CRAN (R 3.6.0)                    
 ps            1.3.2   2020-02-13 [1] CRAN (R 3.6.0)                    
 R6            2.4.1   2019-11-12 [1] CRAN (R 3.6.1)                    
 remotes       2.1.1   2020-02-15 [1] CRAN (R 3.6.0)                    
 rex           1.1.2   2017-10-19 [1] CRAN (R 3.6.0)                    
 rlang         0.4.5   2020-03-01 [1] CRAN (R 3.6.0)                    
 rprojroot     1.3-2   2018-01-03 [1] CRAN (R 3.6.0)                    
 rstudioapi    0.11    2020-02-07 [1] CRAN (R 3.6.0)                    
 sessioninfo * 1.1.1   2018-11-05 [1] CRAN (R 3.6.0)                    
 testthat    * 2.3.2   2020-03-02 [1] CRAN (R 3.6.2)                    
 usethis     * 1.6.0   2020-04-09 [1] CRAN (R 3.6.3)                    
 withr         2.1.2   2018-03-15 [1] CRAN (R 3.6.0)                    
 yaml          2.2.1   2020-02-01 [1] CRAN (R 3.6.0)                    

[1] /Library/Frameworks/R.framework/Versions/3.6/Resources/library

[lcolladotor]

At LieberInstitute/recount3@108ade7 I did something similar to what you did already for one of your repos r-lib/actions@331cc49 (I just noticed we did nearly the same thing hehe)

[jimhester]

While it would be nice to handle this use case I think it is not common enough to worry about for now.

[stefanoborini]

@jimhester when there's a bug, the process normally is not to close it as "we don't care". A bug is a bug and must be fixed, and this is a bug. Leave it open at least.