Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change from serde::export to std::marker #975

Merged
merged 1 commit into from
Jan 12, 2021
Merged

Change from serde::export to std::marker #975

merged 1 commit into from
Jan 12, 2021

Conversation

jamescorbett
Copy link
Contributor

For some reason under a docker build I get a build error under docker only saying that serde::export is private. This fixes it for me.

error[E0603]: module `export` is private
   --> /usr/local/cargo/registry/src/esyshub.st101.workers.dev-1ecc6299db9ec823/tantivy-0.13.2/src/collector/top_collector.rs:5:12
    |
5   | use serde::export::PhantomData;
    |            ^^^^^^ private module
    |
note: the module `export` is defined here
   --> /usr/local/cargo/registry/src/esyshub.st101.workers.dev-1ecc6299db9ec823/serde-1.0.119/src/lib.rs:275:5
    |
275 | use self::__private as export;
    |     ^^^^^^^^^^^^^^^^^^^^^^^^^

For some reason under a docker build I get a build error under docker only saying that `serde::export` is private. This fixes it for me.

```
error[E0603]: module `export` is private
   --> /usr/local/cargo/registry/src/esyshub.st101.workers.dev-1ecc6299db9ec823/tantivy-0.13.2/src/collector/top_collector.rs:5:12
    |
5   | use serde::export::PhantomData;
    |            ^^^^^^ private module
    |
note: the module `export` is defined here
   --> /usr/local/cargo/registry/src/esyshub.st101.workers.dev-1ecc6299db9ec823/serde-1.0.119/src/lib.rs:275:5
    |
275 | use self::__private as export;
    |     ^^^^^^^^^^^^^^^^^^^^^^^^^
```
@fulmicoton fulmicoton merged commit 824ccc3 into quickwit-oss:main Jan 12, 2021
@fulmicoton
Copy link
Collaborator

thx

@appaquet
Copy link
Collaborator

Can a 0.13.3 be released with this fix since it is broken following a patch update on Serde... Unless 0.14 isn't far away ? Thx !

@fulmicoton
Copy link
Collaborator

@appaquet Ok I'll do that today. I don't want to rush on releasing 0.14 as a bug was discovered on the main branch recently, so it will be a 0.13.3

@fulmicoton
Copy link
Collaborator

@appaquet @jamescorbett Published 0.13.3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants