Update QM driver to new acquisition and ChannelId
#998
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Breaks the compatibility with Qibo<0.2.8
In particular, in py3.12
Since it could be possibly unregistered there
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## py3.12 #998 +/- ##
==========================================
- Coverage 42.82% 42.74% -0.08%
==========================================
Files 80 80
Lines 5551 5561 +10
==========================================
Hits 2377 2377
- Misses 3174 3184 +10
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
alecandido
approved these changes
Aug 20, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are the fixes required to make things work with #970. I based it on #994 since this queue of PRs is also ready. I am not sure if it is the best possible way to fix, but was tested to work with single shot routine and qw11qD.
Generally, I am not very happy with this change, I think that both the separate acquisition and
ChannelIdmake things slightly more complicated. The acquisition part was expected, since it is not natively supported by QM (as far as I know), theChannelIdpart requires casting to string several times. However, the difference is not that big and we can still live with it.