Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python 3.12 and Qibo > 0.2.6 #994

Merged
merged 11 commits into from
Aug 22, 2024
Merged

Python 3.12 and Qibo > 0.2.6 #994

merged 11 commits into from
Aug 22, 2024

Conversation

alecandido
Copy link
Member

It was blocked until now, mainly because of QUA (and also Qibosoq, but in qibosoq@main is already 3.12-ready, we simply did not bother to release).

This was also blocking Qibo releases supporting py3.12, and that's why we didn't catch #988 before.

However, I realized that there was a smarter way: just gate QUA to py<3.12, and not the whole Qibolab.

Closes #988

@alecandido alecandido added this to the Qibolab 0.2.0 milestone Aug 19, 2024
Copy link

codecov bot commented Aug 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 42.84%. Comparing base (34cb2fc) to head (3e0ed80).
Report is 28 commits behind head on 0.2.

Additional details and impacted files
@@            Coverage Diff             @@
##              0.2     #994      +/-   ##
==========================================
+ Coverage   42.83%   42.84%   +0.01%     
==========================================
  Files          80       80              
  Lines        5552     5553       +1     
==========================================
+ Hits         2378     2379       +1     
  Misses       3174     3174              
Flag Coverage Δ
unittests 42.84% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alecandido alecandido marked this pull request as ready for review August 19, 2024 11:36
@alecandido alecandido requested a review from stavros11 August 19, 2024 11:36
@alecandido alecandido linked an issue Aug 19, 2024 that may be closed by this pull request
@alecandido
Copy link
Member Author

Btw, even in its latest (pre-)release, https://pypi.org/project/qm-qua/1.2.1a1/, qm-qua is imposing a bound to py<3.12. And I don't see any apparent reason for that, since new versions should be (almost completely) backward compatible.

@stavros11, could you ask them what's the motivation of this version lock?
It's a pure-python library, so they don't have to compile wheels for the new versions...

(unfortunately, it is not open-source, though I could manually inspect the dependencies from the wheel metadata...)

@stavros11
Copy link
Member

@stavros11, could you ask them what's the motivation of this version lock? It's a pure-python library, so they don't have to compile wheels for the new versions...

(unfortunately, it is not open-source, though I could manually inspect the dependencies from the wheel metadata...)

I asked them a similar question about a year ago, when they first added such version lock, initially for py3.11. If you check on pypi qm-qua 1.1.1 did not have such constraints, while from 1.1.2 to 1.1.5 they restricted to py<3.11. At that time they responded that they had to do it because some of their dependencies (I don't know which) did not support py3.11. Then in qm-qua 1.1.6 they added 3.11 support because the dependencies were also updated. I am not sure about 3.12, but it could be a similar problem.

@stavros11 stavros11 mentioned this pull request Aug 22, 2024
Base automatically changed from two-qubit-alignment to 0.2 August 22, 2024 16:30
@alecandido alecandido merged commit 4f8e1c9 into 0.2 Aug 22, 2024
28 checks passed
@alecandido alecandido deleted the py3.12 branch August 22, 2024 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Compiling Align gate to pulse sequence fails
2 participants