-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Python 3.12 and Qibo > 0.2.6 #994
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 0.2 #994 +/- ##
==========================================
+ Coverage 42.83% 42.84% +0.01%
==========================================
Files 80 80
Lines 5552 5553 +1
==========================================
+ Hits 2378 2379 +1
Misses 3174 3174
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Btw, even in its latest (pre-)release, https://pypi.org/project/qm-qua/1.2.1a1/, @stavros11, could you ask them what's the motivation of this version lock? (unfortunately, it is not open-source, though I could manually inspect the dependencies from the wheel metadata...) |
I asked them a similar question about a year ago, when they first added such version lock, initially for py3.11. If you check on pypi qm-qua 1.1.1 did not have such constraints, while from 1.1.2 to 1.1.5 they restricted to py<3.11. At that time they responded that they had to do it because some of their dependencies (I don't know which) did not support py3.11. Then in qm-qua 1.1.6 they added 3.11 support because the dependencies were also updated. I am not sure about 3.12, but it could be a similar problem. |
Breaks the compatibility with Qibo<0.2.8
In particular, in py3.12
Since it could be possibly unregistered there
It was blocked until now, mainly because of QUA (and also Qibosoq, but in
qibosoq@main
is already 3.12-ready, we simply did not bother to release).This was also blocking Qibo releases supporting py3.12, and that's why we didn't catch #988 before.
However, I realized that there was a smarter way: just gate QUA to py<3.12, and not the whole Qibolab.
Closes #988