fix: rescale QM pulse amplitude to [-1, 1] #1010
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 0.2 #1010 +/- ##
==========================================
+ Coverage 42.80% 42.81% +0.01%
==========================================
Files 80 80
Lines 5642 5645 +3
==========================================
+ Hits 2415 2417 +2
- Misses 3227 3228 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
alecandido
approved these changes
Aug 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1006 for QM by multiplying all waveforms with the maximum voltage output (0.5 V), which essentially rescales the meaning of
pulse.amplitudeto [-1, 1].I think this closes the issue for now, we just need to be consistent as we are adding more drivers. Regarding the flux pulse - qubit frequency mapping, it sounds more of a calibration feature, so I am not sure if we should add in qibolab, but this won't happen for 0.2(.0) in any case.